Re: [PATCH v2 06/10] ASoC: wcd9335: add basic controls

2018-08-01 Thread Srinivas Kandagatla
Thanks for the review. On 31/07/18 18:16, Mark Brown wrote: On Fri, Jul 27, 2018 at 01:18:02PM +0100, Srinivas Kandagatla wrote: +static const char * const wcd9335_ear_pa_gain_text[] = { + "G_6_DB", "G_4P5_DB", "G_3_DB", "G_1P5_DB", + "G_0_DB", "G_M2P5_DB", "UNDEFINED", "G_M12_DB"

Re: [PATCH v2 06/10] ASoC: wcd9335: add basic controls

2018-07-31 Thread Mark Brown
On Fri, Jul 27, 2018 at 01:18:02PM +0100, Srinivas Kandagatla wrote: > +static const char * const wcd9335_ear_pa_gain_text[] = { > + "G_6_DB", "G_4P5_DB", "G_3_DB", "G_1P5_DB", > + "G_0_DB", "G_M2P5_DB", "UNDEFINED", "G_M12_DB" > +}; This is fairly clearly a volume control so shouldn't be