Re: [PATCH v2 04/20] gcc-plugins: Add the randstruct plugin

2017-06-30 Thread Arnd Bergmann
On Fri, Jun 30, 2017 at 4:41 PM, Kees Cook wrote: > On Fri, Jun 30, 2017 at 1:27 AM, Arnd Bergmann wrote: >> On Fri, Jun 30, 2017 at 9:55 AM, Ard Biesheuvel >> wrote: >>> On 30 June 2017 at 07:35, Arnd Bergmann wrote: On Fri, Jun 30, 2017 at 12:53 AM, Kees Cook wrote: > The first obvi

Re: [PATCH v2 04/20] gcc-plugins: Add the randstruct plugin

2017-06-30 Thread Kees Cook
On Fri, Jun 30, 2017 at 1:27 AM, Arnd Bergmann wrote: > On Fri, Jun 30, 2017 at 9:55 AM, Ard Biesheuvel > wrote: >> On 30 June 2017 at 07:35, Arnd Bergmann wrote: >>> On Fri, Jun 30, 2017 at 12:53 AM, Kees Cook wrote: The first obviously won't fly. The second just bypasses the problem

Re: [PATCH v2 04/20] gcc-plugins: Add the randstruct plugin

2017-06-30 Thread Arnd Bergmann
On Fri, Jun 30, 2017 at 9:55 AM, Ard Biesheuvel wrote: > On 30 June 2017 at 07:35, Arnd Bergmann wrote: >> On Fri, Jun 30, 2017 at 12:53 AM, Kees Cook wrote: >>> The first obviously won't fly. The second just bypasses the problem >>> forcing it to be exposed by other people later. The third is l

Re: [PATCH v2 04/20] gcc-plugins: Add the randstruct plugin

2017-06-30 Thread Ard Biesheuvel
On 30 June 2017 at 07:35, Arnd Bergmann wrote: > On Fri, Jun 30, 2017 at 12:53 AM, Kees Cook wrote: >> On Thu, Jun 29, 2017 at 3:08 PM, Arnd Bergmann wrote: >>> On Fri, May 26, 2017 at 10:17 PM, Kees Cook wrote: >>> I noticed new build errors that bisected back to this patch, which has >>> now

Re: [PATCH v2 04/20] gcc-plugins: Add the randstruct plugin

2017-06-30 Thread Arnd Bergmann
On Fri, Jun 30, 2017 at 12:53 AM, Kees Cook wrote: > On Thu, Jun 29, 2017 at 3:08 PM, Arnd Bergmann wrote: >> On Fri, May 26, 2017 at 10:17 PM, Kees Cook wrote: >> I noticed new build errors that bisected back to this patch, which has >> now showed up >> in linux-next again: > > (FWIW this is ra

Re: [PATCH v2 04/20] gcc-plugins: Add the randstruct plugin

2017-06-29 Thread Kees Cook
On Thu, Jun 29, 2017 at 3:53 PM, Kees Cook wrote: > I see a few possible solutions: Or this ugly hack: diff --git a/include/linux/sched.h b/include/linux/sched.h index e2ad3531e7fe..5d131f9f1dac 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -749,6 +749,19 @@ struct task_struc

Re: [PATCH v2 04/20] gcc-plugins: Add the randstruct plugin

2017-06-29 Thread Kees Cook
On Thu, Jun 29, 2017 at 3:08 PM, Arnd Bergmann wrote: > On Fri, May 26, 2017 at 10:17 PM, Kees Cook wrote: > I noticed new build errors that bisected back to this patch, which has > now showed up > in linux-next again: (FWIW this is randstruct not initify, and has been in -next for a couple week

Re: [PATCH v2 04/20] gcc-plugins: Add the randstruct plugin

2017-06-29 Thread Arnd Bergmann
On Fri, May 26, 2017 at 10:17 PM, Kees Cook wrote: > This feature is ported from grsecurity. The implementation is almost > entirely identical to the original code written by the PaX Team and > Brad Spengler. Hi Kees, I noticed new build errors that bisected back to this patch, which has now sho