Re: [PATCH v2 04/12] mm: thp: introduce CONFIG_ARCH_ENABLE_THP_MIGRATION

2016-11-29 Thread Michal Hocko
On Tue 29-11-16 07:50:06, Naoya Horiguchi wrote: > On Mon, Nov 28, 2016 at 03:21:54PM +0100, Michal Hocko wrote: > > On Tue 08-11-16 08:31:49, Naoya Horiguchi wrote: > > > Introduces CONFIG_ARCH_ENABLE_THP_MIGRATION to limit thp migration > > > functionality to x86_64, which should be safer at the

Re: [PATCH v2 04/12] mm: thp: introduce CONFIG_ARCH_ENABLE_THP_MIGRATION

2016-11-28 Thread Naoya Horiguchi
On Mon, Nov 28, 2016 at 03:21:54PM +0100, Michal Hocko wrote: > On Tue 08-11-16 08:31:49, Naoya Horiguchi wrote: > > Introduces CONFIG_ARCH_ENABLE_THP_MIGRATION to limit thp migration > > functionality to x86_64, which should be safer at the first step. > > Please make sure to describe why this ha

Re: [PATCH v2 04/12] mm: thp: introduce CONFIG_ARCH_ENABLE_THP_MIGRATION

2016-11-28 Thread Michal Hocko
On Tue 08-11-16 08:31:49, Naoya Horiguchi wrote: > Introduces CONFIG_ARCH_ENABLE_THP_MIGRATION to limit thp migration > functionality to x86_64, which should be safer at the first step. Please make sure to describe why this has to be arch specific and what are arches supposed to provide in order t

Re: [PATCH v2 04/12] mm: thp: introduce CONFIG_ARCH_ENABLE_THP_MIGRATION

2016-11-14 Thread Naoya Horiguchi
On Fri, Nov 11, 2016 at 02:18:40PM +0300, Kirill A. Shutemov wrote: > On Tue, Nov 08, 2016 at 08:31:49AM +0900, Naoya Horiguchi wrote: > > +static inline bool thp_migration_supported(void) > > +{ > > +#ifdef CONFIG_ARCH_ENABLE_THP_MIGRATION > > + return true; > > +#else > > + return false; > >

Re: [PATCH v2 04/12] mm: thp: introduce CONFIG_ARCH_ENABLE_THP_MIGRATION

2016-11-11 Thread Kirill A. Shutemov
On Tue, Nov 08, 2016 at 08:31:49AM +0900, Naoya Horiguchi wrote: > +static inline bool thp_migration_supported(void) > +{ > +#ifdef CONFIG_ARCH_ENABLE_THP_MIGRATION > + return true; > +#else > + return false; > +#endif Em.. return IS_ENABLED(CONFIG_ARCH_ENABLE_THP_MIGRATION); ?