Re: [PATCH v2 03/13] uprobes: allow arch access to xol slot

2013-10-29 Thread Oleg Nesterov
On 10/22, David Long wrote: > > On 10/19/13 12:36, Oleg Nesterov wrote: >> >> How about >> >> void __weak arch_uprobe_xol_copy(...) >> { >> copy_to_page(...); >> } >> >> then just >> >> - copy_to_page(...); >> + arch_uprobe_xol_copy(...); >> >> ? >> > > I was t

Re: [PATCH v2 03/13] uprobes: allow arch access to xol slot

2013-10-22 Thread David Long
On 10/19/13 12:36, Oleg Nesterov wrote: On 10/15, David Long wrote: Allow arches to customize how the instruction is filled into the xol slot. ARM will use this to insert an undefined instruction after the real instruction in order to simulate a single step of the instruction without hardware

Re: [PATCH v2 03/13] uprobes: allow arch access to xol slot

2013-10-19 Thread Oleg Nesterov
On 10/15, David Long wrote: > > Allow arches to customize how the instruction is filled into the xol > slot. ARM will use this to insert an undefined instruction after the > real instruction in order to simulate a single step of the instruction > without hardware support. OK, but > +void __weak