Re: [PATCH v2 02/18] gpio: uapi: define uAPI v2

2020-08-06 Thread Bartosz Golaszewski
On Thu, Aug 6, 2020 at 3:15 AM Kent Gibson wrote: > > On Wed, Aug 05, 2020 at 01:18:53PM +0800, Kent Gibson wrote: > > On Tue, Aug 04, 2020 at 07:42:34PM +0200, Bartosz Golaszewski wrote: > > > On Sat, Jul 25, 2020 at 6:20 AM Kent Gibson wrote: > > [snip] > > > > > config, info, info_changed and

Re: [PATCH v2 02/18] gpio: uapi: define uAPI v2

2020-08-05 Thread Kent Gibson
On Wed, Aug 05, 2020 at 01:18:53PM +0800, Kent Gibson wrote: > On Tue, Aug 04, 2020 at 07:42:34PM +0200, Bartosz Golaszewski wrote: > > On Sat, Jul 25, 2020 at 6:20 AM Kent Gibson wrote: [snip] > > > config, info, info_changed and event structs receive updated versions, > > > and the first three

Re: [PATCH v2 02/18] gpio: uapi: define uAPI v2

2020-08-05 Thread Kent Gibson
On Wed, Aug 05, 2020 at 07:47:57PM +0200, Bartosz Golaszewski wrote: > On Wed, Aug 5, 2020 at 7:19 AM Kent Gibson wrote: > > > > [snip] > > > > > > > > > +/* > > > > + * Maximum number of requested lines. > > > > + * > > > > + * Must be a multiple of 8 to ensure 32/64-bit alignment of structs. >

Re: [PATCH v2 02/18] gpio: uapi: define uAPI v2

2020-08-05 Thread Bartosz Golaszewski
On Wed, Aug 5, 2020 at 7:19 AM Kent Gibson wrote: > [snip] > > > > > > +/* > > > + * Maximum number of requested lines. > > > + * > > > + * Must be a multiple of 8 to ensure 32/64-bit alignment of structs. > > > + */ > > > +#define GPIOLINES_MAX 64 > > > + > > > +/* The number of __u64 required

Re: [PATCH v2 02/18] gpio: uapi: define uAPI v2

2020-08-04 Thread Kent Gibson
On Tue, Aug 04, 2020 at 07:42:34PM +0200, Bartosz Golaszewski wrote: > On Sat, Jul 25, 2020 at 6:20 AM Kent Gibson wrote: > > > > Add a new version of the uAPI to address existing 32/64-bit alignment > > issues, add support for debounce and event sequence numbers, and provide > > some future proof

Re: [PATCH v2 02/18] gpio: uapi: define uAPI v2

2020-08-04 Thread Bartosz Golaszewski
On Sat, Jul 25, 2020 at 6:20 AM Kent Gibson wrote: > > Add a new version of the uAPI to address existing 32/64-bit alignment > issues, add support for debounce and event sequence numbers, and provide > some future proofing by adding padding reserved for future use. > > The alignment issue relates