Re: [PATCH v2 01/20] NFS: Avoid cross-structure casting

2017-05-28 Thread Kees Cook
On Sun, May 28, 2017 at 12:53 AM, Christoph Hellwig wrote: > On Fri, May 26, 2017 at 01:17:05PM -0700, Kees Cook wrote: >> When the call to nfs_devname() fails, the error path attempts to retain >> the error via the mnt variable, but this requires a cast across very >> different types (char * to s

Re: [PATCH v2 01/20] NFS: Avoid cross-structure casting

2017-05-28 Thread Christoph Hellwig
On Fri, May 26, 2017 at 01:17:05PM -0700, Kees Cook wrote: > When the call to nfs_devname() fails, the error path attempts to retain > the error via the mnt variable, but this requires a cast across very > different types (char * to struct vfsmount *), which the upcoming > structure layout randomiz