On 05/12/17 01:54 PM, Serge Semin wrote:
Just because no one said anything before, doesn't mean it's
acceptable. I think that is the official Linux code review mantra ;-)
Okay, if we are going to do it this way, then return ~0 instead. At
least that way there is no ugly cast.
Ok. I'll re
On Tue, Dec 05, 2017 at 01:07:26PM -0500, Jon Mason wrote:
> On Tue, Dec 5, 2017 at 12:31 PM, Serge Semin wrote:
> > On Tue, Dec 05, 2017 at 11:49:10AM -0500, Jon Mason
> > wrote:
> >> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin
> >> wrote:
> >> > There is a common methods signature form used
On 05/12/17 10:31 AM, Serge Semin wrote:
-static int idt_ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx, u32 *msg)
+static u32 idt_ntb_msg_read(struct ntb_dev *ntb, int *pidx, int midx)
{
struct idt_ntb_dev *ndev = to_ndev_ntb(ntb);
if (midx < 0 || IDT_MSG_CNT <= mid
On Tue, Dec 5, 2017 at 12:31 PM, Serge Semin wrote:
> On Tue, Dec 05, 2017 at 11:49:10AM -0500, Jon Mason wrote:
>> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote:
>> > There is a common methods signature form used over all the NTB API
>> > like functions naming scheme, arguments names and or
On Tue, Dec 05, 2017 at 11:49:10AM -0500, Jon Mason wrote:
> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote:
> > There is a common methods signature form used over all the NTB API
> > like functions naming scheme, arguments names and order, etc.
> > Recently added NTB messaging API IO callback
On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote:
> There is a common methods signature form used over all the NTB API
> like functions naming scheme, arguments names and order, etc.
> Recently added NTB messaging API IO callbacks were named a bit
> different so should be renamed to be in complia
6 matches
Mail list logo
