Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-23 Thread Stephane Eranian
Arnaldo, On Wed, Oct 23, 2013 at 4:22 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 23, 2013 at 11:34:42AM +0200, Stephane Eranian escreveu: >> On Wed, Oct 23, 2013 at 12:18 AM, Arnaldo Carvalho de Melo >> > What about: > >> > # perf stat -a -e power/energy-cores/,power/energy-pkg/,ref-cycle

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-23 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 23, 2013 at 11:34:42AM +0200, Stephane Eranian escreveu: > On Wed, Oct 23, 2013 at 12:18 AM, Arnaldo Carvalho de Melo > > What about: > > # perf stat -a -e power/energy-cores/,power/energy-pkg/,ref-cycles -I 1000 > > sleep 1000 > > # time events > >

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-23 Thread Stephane Eranian
Arnaldo, On Wed, Oct 23, 2013 at 12:18 AM, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 22, 2013 at 06:47:38PM +0200, Stephane Eranian escreveu: >> I have updated my RAPL patches to implement the suggested changes. >> I will post the patch very soon. The new look and feel is as folllows: > >> #

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-23 Thread Stephane Eranian
Andi, On Wed, Oct 23, 2013 at 9:07 AM, Andi Kleen wrote: >> # perf stat -a -e power/energy-cores/,power/energy-pkg/,ref-cycles -I >> 1000 sleep 1000 >> # timeunitcounts events >> 1.000264953 Joules 2.09 power/energy-cores/ >> [100.00%] >>

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-23 Thread Andi Kleen
> # perf stat -a -e power/energy-cores/,power/energy-pkg/,ref-cycles -I > 1000 sleep 1000 > # timeunitcounts events > 1.000264953 Joules 2.09 power/energy-cores/ > [100.00%] > 1.000264953 Joules 5.94 power/energy-pkg/ >

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-22 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 22, 2013 at 06:47:38PM +0200, Stephane Eranian escreveu: > I have updated my RAPL patches to implement the suggested changes. > I will post the patch very soon. The new look and feel is as folllows: > # perf stat -a -e power/energy-cores/,power/energy-pkg/,ref-cycles -I > 1000 sleep 1

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-22 Thread Stephane Eranian
Hi, I have updated my RAPL patches to implement the suggested changes. I will post the patch very soon. The new look and feel is as folllows: # perf stat -a -e power/energy-cores/,power/energy-pkg/,ref-cycles -I 1000 sleep 1000 # timeunitcounts events 1.00026495

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-17 Thread Stephane Eranian
Peter, On Thu, Oct 17, 2013 at 11:07 AM, Peter Zijlstra wrote: > On Thu, Oct 17, 2013 at 10:14:20AM +0200, Ingo Molnar wrote: >> > > I.e. you would be encoding the counter unit as the suffix, might as well >> > > call it "power/cores.joules" and use the dot as the separator for the >> > > unit, b

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-17 Thread Borislav Petkov
On Thu, Oct 17, 2013 at 11:07:30AM +0200, Peter Zijlstra wrote: > The downside to such a sysfs entry will be the scope. It would either > be pmu wide (unwieldy for many PMUs) or be only per listed event; and > we really don't want exhaustive event lists in the kernel. So why not teach perf tool to

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-17 Thread Peter Zijlstra
On Thu, Oct 17, 2013 at 10:14:20AM +0200, Ingo Molnar wrote: > > > I.e. you would be encoding the counter unit as the suffix, might as well > > > call it "power/cores.joules" and use the dot as the separator for the > > > unit, but would be just a compact form to encode the counter->unit > > > tabl

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-17 Thread Ingo Molnar
* Stephane Eranian wrote: > On Wed, Oct 16, 2013 at 7:53 PM, Arnaldo Carvalho de Melo > wrote: > > Em Wed, Oct 16, 2013 at 03:13:54PM +0200, Stephane Eranian escreveu: > >> On Wed, Oct 16, 2013 at 2:46 PM, Ingo Molnar wrote: > >> > We should also tell user-space that the unit of this counter i

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-16 Thread Stephane Eranian
On Wed, Oct 16, 2013 at 7:53 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 16, 2013 at 03:13:54PM +0200, Stephane Eranian escreveu: >> On Wed, Oct 16, 2013 at 2:46 PM, Ingo Molnar wrote: >> > We should also tell user-space that the unit of this counter is 'Joule'. >> > >> > Then things like:

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-16 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 16, 2013 at 03:13:54PM +0200, Stephane Eranian escreveu: > On Wed, Oct 16, 2013 at 2:46 PM, Ingo Molnar wrote: > > We should also tell user-space that the unit of this counter is 'Joule'. > > > > Then things like: > > > > perf stat -a -e power/* sleep 1 > > > > would output, wi

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-16 Thread Stephane Eranian
On Wed, Oct 16, 2013 at 2:46 PM, Ingo Molnar wrote: > > So, the RAPL patch-set clearly needs more work. > > * Borislav Petkov wrote: > >> On Thu, Oct 10, 2013 at 04:50:05PM +0200, Stephane Eranian wrote: >> > $ perf stat -a -e rapl/rapl-energy-cores/,rapl/rapl-energy-pkg/ -I 1000 >> > sleep 10 >

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-16 Thread Ingo Molnar
So, the RAPL patch-set clearly needs more work. * Borislav Petkov wrote: > On Thu, Oct 10, 2013 at 04:50:05PM +0200, Stephane Eranian wrote: > > $ perf stat -a -e rapl/rapl-energy-cores/,rapl/rapl-energy-pkg/ -I 1000 > > sleep 10 > > time counts events > > 1.000345

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-10 Thread Borislav Petkov
On Thu, Oct 10, 2013 at 04:50:05PM +0200, Stephane Eranian wrote: > $ perf stat -a -e rapl/rapl-energy-cores/,rapl/rapl-energy-pkg/ -I 1000 sleep > 10 > time counts events > 1.000345931772 278 493 rapl/rapl-energy-cores/ > 1.000345931 55 539 138 560 ra

Re: [PATCH v2 0/3] perf,x86: add Intel RAPL PMU support

2013-10-10 Thread Andi Kleen
Looks all good to me now. Reviewed-by: Andi Kleen -Andi -- a...@linux.intel.com -- Speaking for myself only -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo