Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-22 Thread Murali Karicheri
On 08/21/2014 03:33 PM, Peter Hurley wrote: On 08/09/2014 07:28 AM, Murali Karicheri wrote: On 08/08/2014 06:59 PM, Murali Karicheri wrote: On 08/08/2014 06:09 PM, Peter Hurley wrote: On 08/08/2014 05:02 PM, Murali Karicheri wrote: On 08/08/2014 04:44 PM, Peter Hurley wrote: On 08/08/2014 03

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-21 Thread Peter Hurley
On 08/09/2014 07:28 AM, Murali Karicheri wrote: > On 08/08/2014 06:59 PM, Murali Karicheri wrote: >> On 08/08/2014 06:09 PM, Peter Hurley wrote: >>> On 08/08/2014 05:02 PM, Murali Karicheri wrote: On 08/08/2014 04:44 PM, Peter Hurley wrote: > On 08/08/2014 03:36 PM, Murali Karicheri wrote:

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-19 Thread Murali Karicheri
On 08/09/2014 07:28 AM, Murali Karicheri wrote: On 08/08/2014 06:59 PM, Murali Karicheri wrote: On 08/08/2014 06:09 PM, Peter Hurley wrote: On 08/08/2014 05:02 PM, Murali Karicheri wrote: On 08/08/2014 04:44 PM, Peter Hurley wrote: On 08/08/2014 03:36 PM, Murali Karicheri wrote: On 08/07/201

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-09 Thread Murali Karicheri
On 08/08/2014 06:59 PM, Murali Karicheri wrote: On 08/08/2014 06:09 PM, Peter Hurley wrote: On 08/08/2014 05:02 PM, Murali Karicheri wrote: On 08/08/2014 04:44 PM, Peter Hurley wrote: On 08/08/2014 03:36 PM, Murali Karicheri wrote: On 08/07/2014 07:03 PM, Peter Hurley wrote: [...] But I r

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-08 Thread Murali Karicheri
On 08/08/2014 06:09 PM, Peter Hurley wrote: On 08/08/2014 05:02 PM, Murali Karicheri wrote: On 08/08/2014 04:44 PM, Peter Hurley wrote: On 08/08/2014 03:36 PM, Murali Karicheri wrote: On 08/07/2014 07:03 PM, Peter Hurley wrote: [...] But I realize now that a different question needs asking

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-08 Thread Murali Karicheri
On 08/08/2014 03:36 PM, Murali Karicheri wrote: On 08/07/2014 07:03 PM, Peter Hurley wrote: Cut- 1. The patch enables UPF_HARD_FLOW, but provides no throttle() and unthrottle() methods for 8250, which is guaranteed to blow-up when either uart_throttle() or uart_unthrottle() i

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-08 Thread Peter Hurley
On 08/08/2014 05:02 PM, Murali Karicheri wrote: > On 08/08/2014 04:44 PM, Peter Hurley wrote: >> On 08/08/2014 03:36 PM, Murali Karicheri wrote: >>> On 08/07/2014 07:03 PM, Peter Hurley wrote: >> >> [...] >> But I realize now that a different question needs asking: Is the MSR read showing

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-08 Thread Murali Karicheri
On 08/08/2014 04:44 PM, Peter Hurley wrote: Signed-off-by: Russell King On 08/08/2014 03:36 PM, Murali Karicheri wrote: On 08/07/2014 07:03 PM, Peter Hurley wrote: [...] But I realize now that a different question needs asking: Is the MSR read showing delta CTS set when AFE is on, ever

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-08 Thread Peter Hurley
> Signed-off-by: Russell King On 08/08/2014 03:36 PM, Murali Karicheri wrote: > On 08/07/2014 07:03 PM, Peter Hurley wrote: [...] >> But I realize now that a different question needs asking: >> Is the MSR read showing delta CTS set when AFE is on, ever? > > Unfortunately this was tested on

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-08 Thread Murali Karicheri
On 08/07/2014 07:03 PM, Peter Hurley wrote: Cut- 1. The patch enables UPF_HARD_FLOW, but provides no throttle() and unthrottle() methods for 8250, which is guaranteed to blow-up when either uart_throttle() or uart_unthrottle() is called. 2. The patch adds capabilities which a

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-07 Thread Peter Hurley
[ +cc Alan ] On 08/07/2014 04:46 PM, Murali Karicheri wrote: > On 08/07/2014 02:33 PM, Peter Hurley wrote: >> On 08/07/2014 01:34 PM, Murali Karicheri wrote: >>> On 08/07/2014 01:25 PM, Peter Hurley wrote: On 08/07/2014 01:12 PM, Greg Kroah-Hartman wrote: > On Thu, Aug 07, 2014 at 12:16:5

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-07 Thread Murali Karicheri
On 08/07/2014 02:33 PM, Peter Hurley wrote: On 08/07/2014 01:34 PM, Murali Karicheri wrote: On 08/07/2014 01:25 PM, Peter Hurley wrote: On 08/07/2014 01:12 PM, Greg Kroah-Hartman wrote: On Thu, Aug 07, 2014 at 12:16:59PM -0400, Murali Karicheri wrote: On 08/07/2014 11:29 AM, Peter Hurley wrot

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-07 Thread Peter Hurley
On 08/07/2014 01:34 PM, Murali Karicheri wrote: > On 08/07/2014 01:25 PM, Peter Hurley wrote: >> On 08/07/2014 01:12 PM, Greg Kroah-Hartman wrote: >>> On Thu, Aug 07, 2014 at 12:16:59PM -0400, Murali Karicheri wrote: On 08/07/2014 11:29 AM, Peter Hurley wrote: > On 05/01/2014 03:04 PM, Mur

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-07 Thread Murali Karicheri
On 08/07/2014 01:25 PM, Peter Hurley wrote: On 08/07/2014 01:12 PM, Greg Kroah-Hartman wrote: On Thu, Aug 07, 2014 at 12:16:59PM -0400, Murali Karicheri wrote: On 08/07/2014 11:29 AM, Peter Hurley wrote: On 05/01/2014 03:04 PM, Murali Karicheri wrote: 8250 uart driver currently supports only

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-07 Thread Peter Hurley
On 08/07/2014 01:12 PM, Greg Kroah-Hartman wrote: > On Thu, Aug 07, 2014 at 12:16:59PM -0400, Murali Karicheri wrote: >> On 08/07/2014 11:29 AM, Peter Hurley wrote: >>> On 05/01/2014 03:04 PM, Murali Karicheri wrote: 8250 uart driver currently supports only software assisted hw flow contr

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-07 Thread Murali Karicheri
On 08/07/2014 01:12 PM, Greg Kroah-Hartman wrote: On Thu, Aug 07, 2014 at 12:16:59PM -0400, Murali Karicheri wrote: On 08/07/2014 11:29 AM, Peter Hurley wrote: On 05/01/2014 03:04 PM, Murali Karicheri wrote: 8250 uart driver currently supports only software assisted hw flow control. The softwa

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-07 Thread Greg Kroah-Hartman
On Thu, Aug 07, 2014 at 12:16:59PM -0400, Murali Karicheri wrote: > On 08/07/2014 11:29 AM, Peter Hurley wrote: > >On 05/01/2014 03:04 PM, Murali Karicheri wrote: > >>8250 uart driver currently supports only software assisted hw flow > >>control. The software assisted hw flow control maintains a hw

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-07 Thread Murali Karicheri
On 08/07/2014 11:29 AM, Peter Hurley wrote: On 05/01/2014 03:04 PM, Murali Karicheri wrote: 8250 uart driver currently supports only software assisted hw flow control. The software assisted hw flow control maintains a hw_stopped flag in the tty structure to stop and start transmission and use mo

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-08-07 Thread Peter Hurley
On 05/01/2014 03:04 PM, Murali Karicheri wrote: > 8250 uart driver currently supports only software assisted hw flow > control. The software assisted hw flow control maintains a hw_stopped > flag in the tty structure to stop and start transmission and use modem > status interrupt for the event to d

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-06-11 Thread Dann Frazier
On Wed, Jun 11, 2014 at 2:53 PM, Murali Karicheri wrote: > On 5/28/2014 4:04 PM, Dann Frazier wrote: >> >> On Thu, May 1, 2014 at 1:04 PM, Murali Karicheri >> wrote: >>> >>> 8250 uart driver currently supports only software assisted hw flow >>> control. The software assisted hw flow control maint

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-06-11 Thread Murali Karicheri
On 5/28/2014 4:04 PM, Dann Frazier wrote: On Thu, May 1, 2014 at 1:04 PM, Murali Karicheri wrote: 8250 uart driver currently supports only software assisted hw flow control. The software assisted hw flow control maintains a hw_stopped flag in the tty structure to stop and start transmission and

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-05-28 Thread Dann Frazier
On Thu, May 1, 2014 at 1:04 PM, Murali Karicheri wrote: > 8250 uart driver currently supports only software assisted hw flow > control. The software assisted hw flow control maintains a hw_stopped > flag in the tty structure to stop and start transmission and use modem > status interrupt for the e

RE: [PATCH v2] serial: uart: add hw flow control support configuration

2014-05-09 Thread Karicheri, Muralidharan
>-Original Message- >From: Karicheri, Muralidharan >Sent: Thursday, May 01, 2014 3:05 PM >To: devicet...@vger.kernel.org; linux-...@vger.kernel.org; >linux-kernel@vger.kernel.org; >linux-ser...@vger.kernel.org >Cc: Karicheri, Muralidharan; Rob Herring; Pawel Moll; Mark Rutland; Ian >Campb