Re: [PATCH v2] scsi: 3w-9xxx: Fix endianness issues found by sparse

2020-08-08 Thread Samuel Holland
On 8/5/20 2:17 AM, Arnd Bergmann wrote: > On Wed, Aug 5, 2020 at 3:44 AM Samuel Holland wrote: >> On 8/3/20 9:02 AM, Arnd Bergmann wrote: >>> On Mon, Aug 3, 2020 at 5:42 AM Samuel Holland wrote: All of the command structures are packed, due to the "#pragma pack(1)" earlier in the

Re: [PATCH v2] scsi: 3w-9xxx: Fix endianness issues found by sparse

2020-08-05 Thread Arnd Bergmann
On Wed, Aug 5, 2020 at 3:44 AM Samuel Holland wrote: > On 8/3/20 9:02 AM, Arnd Bergmann wrote: > > On Mon, Aug 3, 2020 at 5:42 AM Samuel Holland wrote: > >> All of the command structures are packed, due to the "#pragma pack(1)" > >> earlier > >> in the file. So alignment is not an issue. This dm

Re: [PATCH v2] scsi: 3w-9xxx: Fix endianness issues found by sparse

2020-08-04 Thread Samuel Holland
On 8/3/20 9:02 AM, Arnd Bergmann wrote: > On Mon, Aug 3, 2020 at 5:42 AM Samuel Holland wrote: >> On 7/31/20 2:29 AM, Arnd Bergmann wrote: >>> On Fri, Jul 31, 2020 at 12:07 AM Samuel Holland wrote: The main issue observed was at the call to scsi_set_resid, where the byteswapped par

Re: [PATCH v2] scsi: 3w-9xxx: Fix endianness issues found by sparse

2020-08-03 Thread Arnd Bergmann
On Mon, Aug 3, 2020 at 5:42 AM Samuel Holland wrote: > > On 7/31/20 2:29 AM, Arnd Bergmann wrote: > > On Fri, Jul 31, 2020 at 12:07 AM Samuel Holland wrote: > >> > >> The main issue observed was at the call to scsi_set_resid, where the > >> byteswapped parameter would eventually trigger the align

Re: [PATCH v2] scsi: 3w-9xxx: Fix endianness issues found by sparse

2020-08-02 Thread Samuel Holland
On 7/31/20 2:29 AM, Arnd Bergmann wrote: > On Fri, Jul 31, 2020 at 12:07 AM Samuel Holland wrote: >> >> The main issue observed was at the call to scsi_set_resid, where the >> byteswapped parameter would eventually trigger the alignment check at >> drivers/scsi/sd.c:2009. At that point, the kernel

Re: [PATCH v2] scsi: 3w-9xxx: Fix endianness issues found by sparse

2020-07-31 Thread Arnd Bergmann
On Fri, Jul 31, 2020 at 12:07 AM Samuel Holland wrote: > > The main issue observed was at the call to scsi_set_resid, where the > byteswapped parameter would eventually trigger the alignment check at > drivers/scsi/sd.c:2009. At that point, the kernel would continuously > complain about an "Unalig