Re: [PATCH v2] mmc: sdhci-msm: Add sdhci_reset() implementation

2017-01-18 Thread Georgi Djakov
On 01/18/2017 01:47 PM, Ritesh Harjani wrote: Hi Georgi, I checked this patch again on internal msm8996 target which has more than 1 core. And I can still see below issue with this patch. Please check the dmesg log snip. (I enabled card runtime suspend/resume to reproduce this more frequently).

Re: [PATCH v2] mmc: sdhci-msm: Add sdhci_reset() implementation

2017-01-18 Thread Ritesh Harjani
Hi Georgi, I checked this patch again on internal msm8996 target which has more than 1 core. And I can still see below issue with this patch. Please check the dmesg log snip. (I enabled card runtime suspend/resume to reproduce this more frequently). In that case we still need to work over th

Re: [PATCH v2] mmc: sdhci-msm: Add sdhci_reset() implementation

2017-01-18 Thread Ritesh Harjani
Hi Georgi, Sorry for delaying this. I did check with HW folks here, but it seems like we still don't have confirmation. In case if I get any new updates later, we can revisit it. Also I see that we have the same implementation in current driver for changing IO voltage. In that case I think th

Re: [PATCH v2] mmc: sdhci-msm: Add sdhci_reset() implementation

2016-12-03 Thread Ritesh Harjani
On 12/1/2016 11:38 PM, Georgi Djakov wrote: On 11/29/2016 05:40 AM, Ritesh Harjani wrote: Hi Georgi, On 11/28/2016 11:09 PM, Georgi Djakov wrote: On apq8016, apq8084 and apq8074 platforms, writing to the software reset register triggers the "power irq". We need to ack and handle the irq, oth

Re: [PATCH v2] mmc: sdhci-msm: Add sdhci_reset() implementation

2016-12-01 Thread Georgi Djakov
On 11/29/2016 05:40 AM, Ritesh Harjani wrote: Hi Georgi, On 11/28/2016 11:09 PM, Georgi Djakov wrote: On apq8016, apq8084 and apq8074 platforms, writing to the software reset register triggers the "power irq". We need to ack and handle the irq, otherwise the following message appears: mmc0: Re

Re: [PATCH v2] mmc: sdhci-msm: Add sdhci_reset() implementation

2016-11-28 Thread Ritesh Harjani
Hi Georgi, On 11/28/2016 11:09 PM, Georgi Djakov wrote: On apq8016, apq8084 and apq8074 platforms, writing to the software reset register triggers the "power irq". We need to ack and handle the irq, otherwise the following message appears: mmc0: Reset 0x1 never completed. sdhci: === REG