Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages

2015-02-23 Thread Vlastimil Babka
On 23.2.2015 20:43, Rik van Riel wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/23/2015 02:16 PM, Andrew Morton wrote: On Wed, 18 Feb 2015 19:08:12 -0500 Rik van Riel wrote: If so, this might be rather undesirable behaviour in some situations (and ditto the current behaviour for p

Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages

2015-02-23 Thread Rik van Riel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/23/2015 02:16 PM, Andrew Morton wrote: > On Wed, 18 Feb 2015 19:08:12 -0500 Rik van Riel > wrote: >>> If so, this might be rather undesirable behaviour in some >>> situations (and ditto the current behaviour for pte_none >>> ptes)? >>> >>> Th

Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages

2015-02-23 Thread Andrew Morton
On Wed, 18 Feb 2015 19:08:12 -0500 Rik van Riel wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/18/2015 06:31 PM, Andrew Morton wrote: > > On Wed, 11 Feb 2015 23:03:55 +0200 Ebru Akagunduz > > wrote: > > > >> This patch improves THP collapse rates, by allowing zero pages. >

Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages

2015-02-20 Thread Andrea Arcangeli
On Wed, Feb 18, 2015 at 03:31:19PM -0800, Andrew Morton wrote: > On Wed, 11 Feb 2015 23:03:55 +0200 Ebru Akagunduz > wrote: > > > This patch improves THP collapse rates, by allowing zero pages. > > > > Currently THP can collapse 4kB pages into a THP when there > > are up to khugepaged_max_ptes_

Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages

2015-02-19 Thread Vlastimil Babka
On 02/19/2015 01:08 AM, Rik van Riel wrote: > On 02/18/2015 06:31 PM, Andrew Morton wrote: >> On Wed, 11 Feb 2015 23:03:55 +0200 Ebru Akagunduz >> wrote: > >>> This patch improves THP collapse rates, by allowing zero pages. >>> >>> Currently THP can collapse 4kB pages into a THP when there are u

Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages

2015-02-18 Thread Rik van Riel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/18/2015 06:31 PM, Andrew Morton wrote: > On Wed, 11 Feb 2015 23:03:55 +0200 Ebru Akagunduz > wrote: > >> This patch improves THP collapse rates, by allowing zero pages. >> >> Currently THP can collapse 4kB pages into a THP when there are up >>

Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages

2015-02-18 Thread Andrew Morton
On Wed, 11 Feb 2015 23:03:55 +0200 Ebru Akagunduz wrote: > This patch improves THP collapse rates, by allowing zero pages. > > Currently THP can collapse 4kB pages into a THP when there > are up to khugepaged_max_ptes_none pte_none ptes in a 2MB > range. This patch counts pte none and mapped z

Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages

2015-02-16 Thread Vlastimil Babka
On 02/11/2015 10:03 PM, Ebru Akagunduz wrote: > This patch improves THP collapse rates, by allowing zero pages. > > Currently THP can collapse 4kB pages into a THP when there > are up to khugepaged_max_ptes_none pte_none ptes in a 2MB > range. This patch counts pte none and mapped zero pages > wi

Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages

2015-02-11 Thread Andrea Arcangeli
On Thu, Feb 12, 2015 at 12:21:40AM +0200, Kirill A. Shutemov wrote: > On Wed, Feb 11, 2015 at 11:16:00PM +0100, Andrea Arcangeli wrote: > > On Wed, Feb 11, 2015 at 11:03:55PM +0200, Ebru Akagunduz wrote: > > > Changes in v2: > > > - Check zero pfn in release_pte_pages() (Andrea Arcangeli) > > > >

Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages

2015-02-11 Thread Kirill A. Shutemov
On Wed, Feb 11, 2015 at 11:16:00PM +0100, Andrea Arcangeli wrote: > On Wed, Feb 11, 2015 at 11:03:55PM +0200, Ebru Akagunduz wrote: > > Changes in v2: > > - Check zero pfn in release_pte_pages() (Andrea Arcangeli) > > .. and in: > > > @@ -2237,7 +2237,7 @@ static void __collapse_huge_page_copy(p

Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages

2015-02-11 Thread Andrea Arcangeli
On Wed, Feb 11, 2015 at 11:03:55PM +0200, Ebru Akagunduz wrote: > Changes in v2: > - Check zero pfn in release_pte_pages() (Andrea Arcangeli) .. and in: > @@ -2237,7 +2237,7 @@ static void __collapse_huge_page_copy(pte_t *pte, > struct page *page, > pte_t pteval = *_pte; >