On Wed, Oct 03, 2012 at 01:04:33PM -0300, Fabio Estevam wrote:
> On Mon, Oct 1, 2012 at 7:22 AM, Mark Brown
> > I don't understand what this irq_chip or the custom domain you're adding
> > are for?
> I declared da9052_irq_chip because I do the following:
> irq_set_chip_and_handler(virq, &da9052_
On Mon, Oct 1, 2012 at 7:22 AM, Mark Brown
wrote:
> On Fri, Sep 28, 2012 at 05:34:18PM -0300, Fabio Estevam wrote:
>
>> +static struct irq_chip da9052_irq_chip = {
>> + .name = "da9052",
>> + .irq_disable= da9052_irq_disable,
>> + .irq_enable =
On Fri, Sep 28, 2012 at 05:34:18PM -0300, Fabio Estevam wrote:
> +static struct irq_chip da9052_irq_chip = {
> + .name = "da9052",
> + .irq_disable= da9052_irq_disable,
> + .irq_enable = da9052_irq_enable,
> +};
I don't understand what this ir
On Fri, Sep 28, 2012 at 12:51 PM, Mark Brown
wrote:
> Well, I'd really rather fix it to work with linear domains while we're
> at it. Right now it's mostly working by accident rather than design
Ok, does the conversion patch below look fine, please?
---
drivers/mfd/da9052-core.c | 9
On Fri, Sep 28, 2012 at 12:37:35PM -0300, Fabio Estevam wrote:
> On Fri, Sep 28, 2012 at 11:29 AM, Mark Brown
> > No, this doesn't support linear domains, if you're going to do this it'd
> > be better to just leave it as irq_base though as discussed that's not
> > ideal. When I've done these conv
On Fri, Sep 28, 2012 at 11:29 AM, Mark Brown
wrote:
> No, this doesn't support linear domains, if you're going to do this it'd
> be better to just leave it as irq_base though as discussed that's not
> ideal. When I've done these conversions I've just done the virq
> conversion at every use.
Ok,
On Fri, Sep 28, 2012 at 11:33:24AM -0300, Fabio Estevam wrote:
> Would you prefer the version below? If so, I can send it as v3:
> - da9052->irq_base = regmap_irq_chip_get_base(da9052->irq_data);
> + da9052->irq = regmap_irq_get_virq(da9052->irq_data, 0);
No, this doesn't support linear
Hi Mark,
Mark Brown wrote:
> On Thu, Sep 27, 2012 at 10:57:38PM -0300, Fabio Estevam wrote:
>
>> -da9052->irq_base = regmap_irq_chip_get_base(da9052->irq_data);
>> +da9052->irq = regmap_irq_get_virq(da9052->irq_data, DA9052_IRQ_ADC_EOM);
>>
>> -ret = request_threaded_irq(DA9052_IRQ_
On Friday 28 September 2012, Mark Brown wrote:
> On Fri, Sep 28, 2012 at 06:42:05AM +, Arnd Bergmann wrote:
> > On Friday 28 September 2012, Fabio Estevam wrote:
>
> > > I also plan to convert the other da9052 drivers to use
> > > regmap_irq_get_virq().
>
> > Ok, I think they have to be subm
On Friday 28 September 2012, Fabio Estevam wrote:
> On Fri, Sep 28, 2012 at 3:42 AM, Arnd Bergmann wrote:
>
> > This looks good.
> >
> >> I also plan to convert the other da9052 drivers to use
> >> regmap_irq_get_virq().
> >
> > Ok, I think they have to be submitted together though, because othe
On Fri, Sep 28, 2012 at 06:42:05AM +, Arnd Bergmann wrote:
> On Friday 28 September 2012, Fabio Estevam wrote:
> > I also plan to convert the other da9052 drivers to use
> > regmap_irq_get_virq().
> Ok, I think they have to be submitted together though, because otherwise
> the other drivers
On Thu, Sep 27, 2012 at 10:57:38PM -0300, Fabio Estevam wrote:
> - da9052->irq_base = regmap_irq_chip_get_base(da9052->irq_data);
> + da9052->irq = regmap_irq_get_virq(da9052->irq_data, DA9052_IRQ_ADC_EOM);
>
> - ret = request_threaded_irq(DA9052_IRQ_ADC_EOM, NULL, da9052_auxadc_irq,
Hi Arnd,
On Fri, Sep 28, 2012 at 3:42 AM, Arnd Bergmann wrote:
> This looks good.
>
>> I also plan to convert the other da9052 drivers to use regmap_irq_get_virq().
>
> Ok, I think they have to be submitted together though, because otherwise
> the other drivers are more broken now.
Yes, makes s
On Friday 28 September 2012, Fabio Estevam wrote:
> ---
> Changes since v2:
> - Use regmap_irq_get_virq() instead of relying on irq_base
This looks good.
> I also plan to convert the other da9052 drivers to use regmap_irq_get_virq().
Ok, I think they have to be submitted together though, because
14 matches
Mail list logo
