Re: [PATCH v2] media: vimc: fla: Add virtual flash subdevice

2019-09-28 Thread Lucas Magalhães
Hi Hans, Thanks for the review. Sorry about the style mistakes, will be careful next time. Just a couple of questions. On Fri, Sep 20, 2019 at 8:32 AM Hans Verkuil wrote: > > > +static int vimc_fla_s_ctrl(struct v4l2_ctrl *c) > > +{ > > + > > + struct vimc_fla_device *vfla = > > +

Re: [PATCH v2] media: vimc: fla: Add virtual flash subdevice

2019-09-24 Thread Dafna Hirschfeld
Hi, On Sun, 2019-09-15 at 15:44 -0300, Lucas A. M. Magalhães wrote: > From: Lucas A. M. Magalhaes > > Add a virtual subdevice to simulate the flash control API. > Those are the supported controls: > v4l2-ctl -d /dev/v4l-subdev6 -L > Flash Controls > >led_mode 0x009c0901

Re: [PATCH v2] media: vimc: fla: Add virtual flash subdevice

2019-09-20 Thread Hans Verkuil
On 9/15/19 8:44 PM, Lucas A. M. Magalhães wrote: > From: Lucas A. M. Magalhaes > > Add a virtual subdevice to simulate the flash control API. > Those are the supported controls: > v4l2-ctl -d /dev/v4l-subdev6 -L > Flash Controls > >led_mode 0x009c0901 (menu) : min=0 max