Re: [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds

2015-10-27 Thread Matt Fleming
On Tue, 27 Oct, at 11:33:55AM, Ard Biesheuvel wrote: > > Does UEFI even allow that? Even if it can describe memory over 4 GB, > it uses a flat mapping so allocations done by the stub (which > retrieves the memory map) should never reside at addresses over 4 GB. Right, exactly. We're good with phy

Re: [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds

2015-10-26 Thread Ard Biesheuvel
On 27 October 2015 at 06:02, Matt Fleming wrote: > On Fri, 23 Oct, at 10:37:46AM, Ard Biesheuvel wrote: >> >> After looking at the original (already merged) patch 11/11 again, I >> realize this is still not right: the problem is that efi_memory_map's >> phys_map member uses a void* type to hold a

Re: [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds

2015-10-26 Thread Matt Fleming
On Fri, 23 Oct, at 10:37:46AM, Ard Biesheuvel wrote: > > After looking at the original (already merged) patch 11/11 again, I > realize this is still not right: the problem is that efi_memory_map's > phys_map member uses a void* type to hold a physical address, which > happens to be correct in the

Re: [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds

2015-10-23 Thread Ingo Molnar
* Ard Biesheuvel wrote: > On 23 October 2015 at 11:50, Taku Izumi wrote: > > commit-0f96a99 introduces the following warning message: > > > > drivers/firmware/efi/fake_mem.c:186:20: warning: cast to pointer > > from integer of different size [-Wint-to-pointer-cast] > > > > new_memmap_phy wa

Re: [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds

2015-10-23 Thread Ingo Molnar
* Taku Izumi wrote: > commit-0f96a99 introduces the following warning message: > > drivers/firmware/efi/fake_mem.c:186:20: warning: cast to pointer > from integer of different size [-Wint-to-pointer-cast] > > new_memmap_phy was defined as a u64 value and casted to void*. > This causes a wa

Re: [PATCH v2] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds

2015-10-23 Thread Ard Biesheuvel
On 23 October 2015 at 11:50, Taku Izumi wrote: > commit-0f96a99 introduces the following warning message: > > drivers/firmware/efi/fake_mem.c:186:20: warning: cast to pointer > from integer of different size [-Wint-to-pointer-cast] > > new_memmap_phy was defined as a u64 value and casted to vo