Re: [PATCH v2] dt-bindings: mfd: correct interrupt flags in examples

2020-09-29 Thread Krzysztof Kozlowski
On Tue, Sep 29, 2020 at 10:46:57AM +0100, Lee Jones wrote: > On Thu, 17 Sep 2020, Krzysztof Kozlowski wrote: > > > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > > These are simple defines so they could be used in DTS but they will not > > have the same meaning: > > 1. GP

Re: [PATCH v2] dt-bindings: mfd: correct interrupt flags in examples

2020-09-29 Thread Lee Jones
On Thu, 17 Sep 2020, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE

Re: [PATCH v2] dt-bindings: mfd: correct interrupt flags in examples

2020-09-29 Thread Lee Jones
On Thu, 17 Sep 2020, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE