Re: [PATCH v2] drivers: cpufreq: Mark function as static in cpufreq.c

2014-03-02 Thread Viresh Kumar
On 3 March 2014 09:12, Patrick Palka wrote: > -Wmissing-prototypes warns when a non-static function is defined > before a corresponding prototype (usually inside an included header > file) is declared. In such a case, it is impossible to reference the > non-static function from another file, and

Re: [PATCH v2] drivers: cpufreq: Mark function as static in cpufreq.c

2014-03-02 Thread Patrick Palka
On Thu, Feb 27, 2014 at 12:25 AM, Viresh Kumar wrote: > Hi Rashika, > > On 26 February 2014 22:08, Rashika Kheria wrote: >> Mark function as static in cpufreq.c because it is not >> used outside this file. >> >> This eliminates the following warning in cpufreq.c: >> drivers/cpufreq/cpufreq.c:355:

Re: [PATCH v2] drivers: cpufreq: Mark function as static in cpufreq.c

2014-03-02 Thread Viresh Kumar
On 27 February 2014 10:55, Viresh Kumar wrote: > Hi Rashika, > > On 26 February 2014 22:08, Rashika Kheria wrote: >> Mark function as static in cpufreq.c because it is not >> used outside this file. >> >> This eliminates the following warning in cpufreq.c: >> drivers/cpufreq/cpufreq.c:355:9: warn

Re: [PATCH v2] drivers: cpufreq: Mark function as static in cpufreq.c

2014-02-26 Thread Viresh Kumar
Hi Rashika, On 26 February 2014 22:08, Rashika Kheria wrote: > Mark function as static in cpufreq.c because it is not > used outside this file. > > This eliminates the following warning in cpufreq.c: > drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for > 'show_boost' [-Wmissing-

Re: [PATCH v2] drivers: cpufreq: Mark function as static in cpufreq.c

2014-02-26 Thread Josh Triplett
On Wed, Feb 26, 2014 at 10:15:57PM +0530, Rashika Kheria wrote: > On Wed, Feb 26, 2014 at 10:11 PM, Josh Triplett wrote: > > On Wed, Feb 26, 2014 at 10:08:26PM +0530, Rashika Kheria wrote: > >> Mark function as static in cpufreq.c because it is not > >> used outside this file. > >> > >> This elimi

Re: [PATCH v2] drivers: cpufreq: Mark function as static in cpufreq.c

2014-02-26 Thread Dirk Brandewie
On 02/26/2014 08:41 AM, Josh Triplett wrote: On Wed, Feb 26, 2014 at 10:08:26PM +0530, Rashika Kheria wrote: Mark function as static in cpufreq.c because it is not used outside this file. This eliminates the following warning in cpufreq.c: drivers/cpufreq/cpufreq.c:355:9: warning: no previous p

Re: [PATCH v2] drivers: cpufreq: Mark function as static in cpufreq.c

2014-02-26 Thread Rashika Kheria
On Wed, Feb 26, 2014 at 10:11 PM, Josh Triplett wrote: > On Wed, Feb 26, 2014 at 10:08:26PM +0530, Rashika Kheria wrote: >> Mark function as static in cpufreq.c because it is not >> used outside this file. >> >> This eliminates the following warning in cpufreq.c: >> drivers/cpufreq/cpufreq.c:355:9

Re: [PATCH v2] drivers: cpufreq: Mark function as static in cpufreq.c

2014-02-26 Thread Josh Triplett
On Wed, Feb 26, 2014 at 10:08:26PM +0530, Rashika Kheria wrote: > Mark function as static in cpufreq.c because it is not > used outside this file. > > This eliminates the following warning in cpufreq.c: > drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for > ‘show_boost’ [-Wmissin