Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

2015-05-16 Thread Martin Sperl
> On 12.05.2015, at 17:58, Noralf Trønnes wrote: > > Is there something missing for this patch to get accepted? > spi-bcm2835 has now DMA support that depends on this patch. As the spi-bcm2835.c patch using DMA (relying on this) has gone into spi/for-next (but so far without the DT changes to e

Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

2015-05-12 Thread Noralf Trønnes
Hi, Den 18.04.2015 13:06, skrev Noralf Trønnes: Add slave transfer capability to BCM2835 dmaengine driver. This patch is pulled from the bcm2708-dmaengine driver in the Raspberry Pi repo. The work was done by Gellert Weisz. Tested using the bcm2835-mmc driver from the same repo. Signed-off-by:

Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

2015-05-10 Thread Martin Sperl
> On 08.05.2015, at 13:20, Jonathan Bell wrote: >> > I agree that the interrupt generated would be spurious - in the case where it > is not required. > > However if you do && (flags & DMA_PREP_INTERRUPT) then all users of this > driver need to explicitly set interrupt flags when doing a scatt

Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

2015-05-08 Thread Jonathan Bell
On 06/05/2015 20:21, Noralf Trønnes wrote: Den 01.05.2015 23:07, skrev Martin Sperl: Tests with the initial (and incomplete) version of the spi-bcm2835 driver with DMA transfer support show that the dma-engine works as expected with this patch. There is one one observation: On 18.04.2015,

Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

2015-05-06 Thread Noralf Trønnes
Den 01.05.2015 23:07, skrev Martin Sperl: Tests with the initial (and incomplete) version of the spi-bcm2835 driver with DMA transfer support show that the dma-engine works as expected with this patch. There is one one observation: On 18.04.2015, at 13:06, Noralf Trønnes wrote: +static struc

Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

2015-05-03 Thread Martin Sperl
I did tests with the (almost) finished dma-support of spi-bcm2835 against a TFT device and it work fine there. Upstreaming this spi-bcm2835 patch obviously requires that the DMA support is in the dma-engine driver first... Please also see prior note about unnecessary interrupts when none are requ

Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

2015-05-01 Thread Martin Sperl
Tests with the initial (and incomplete) version of the spi-bcm2835 driver with DMA transfer support show that the dma-engine works as expected with this patch. There is one one observation: > On 18.04.2015, at 13:06, Noralf Trønnes wrote: > +static struct dma_async_tx_descriptor * > +bcm2835_d