Re: [PATCH v2] PCI: qcom: Use default config space read function

2019-03-14 Thread Marc Gonzalez
On 14/03/2019 12:10, Srinivas Kandagatla wrote: > Here is the output: https://paste.ubuntu.com/p/kFWZ4kXCxT/ Could you test the following patch: And report boot log as well as output of lspci -vv ? diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-

Re: [PATCH v2] PCI: qcom: Use default config space read function

2019-03-14 Thread Srinivas Kandagatla
On 13/03/2019 22:26, Marc Gonzalez wrote: I needed to see the numeric values, hence the -n flag;-) lspci -vvv -n Here is the output: https://paste.ubuntu.com/p/kFWZ4kXCxT/ Thanks, srini Regards.

Re: [PATCH v2] PCI: qcom: Use default config space read function

2019-03-13 Thread Marc Gonzalez
On 13/03/2019 22:52, Srinivas Kandagatla wrote: > On 13/03/2019 20:39, Marc Gonzalez wrote: > >> Could you pastebin the output of lspci -vvv -n in the working case? > > This was already in my original reply: > working without patch : https://paste.ubuntu.com/p/TJm4hgjGW4/ I needed to see the nume

Re: [PATCH v2] PCI: qcom: Use default config space read function

2019-03-13 Thread Srinivas Kandagatla
On 13/03/2019 20:39, Marc Gonzalez wrote: working without patch :https://paste.ubuntu.com/p/TJm4hgjGW4/ I have not debugged it any further other than just testing the patch. Let me know if you need any more dumps for more debug. Could you pastebin the output of lspci -vvv -n in the working c

Re: [PATCH v2] PCI: qcom: Use default config space read function

2019-03-13 Thread Marc Gonzalez
On 13/03/2019 19:29, Srinivas Kandagatla wrote: > On 13/03/2019 11:45, Marc Gonzalez wrote: > >> We don't need to fudge the device class in qcom_pcie_rd_own_conf() >> because dw_pcie_setup_rc() already does the right thing: >> >> /* Program correct class for RC */ >> dw_pcie_wr_own_conf(

Re: [PATCH v2] PCI: qcom: Use default config space read function

2019-03-13 Thread Srinivas Kandagatla
Hi Marc, On 13/03/2019 11:45, Marc Gonzalez wrote: We don't need to fudge the device class in qcom_pcie_rd_own_conf() because dw_pcie_setup_rc() already does the right thing: /* Program correct class for RC */ dw_pcie_wr_own_conf(pp, PCI_CLASS_DEVICE, 2, PCI_CLASS_BRIDGE_PCI);

Re: [PATCH v2] PCI: qcom: Use default config space read function

2019-03-13 Thread Marc Gonzalez
On 13/03/2019 12:45, Marc Gonzalez wrote: > We don't need to fudge the device class in qcom_pcie_rd_own_conf() > because dw_pcie_setup_rc() already does the right thing: > > /* Program correct class for RC */ > dw_pcie_wr_own_conf(pp, PCI_CLASS_DEVICE, 2, PCI_CLASS_BRIDGE_PCI); qcom-