Re: [PATCH v2] Input: synaptics - use firmware data for Cr-48

2012-07-27 Thread Daniel Kurtz
On Sat, Jul 21, 2012 at 2:31 AM, Chase Douglas wrote: > > On 07/20/2012 02:03 AM, Daniel Kurtz wrote: >> >> * Leave the device as SEMI_MT, but provide the real locations, and >> allow userspace to determine the device vendor/model/etc. If >> userspace knows that a specific device b

Re: [PATCH v2] Input: synaptics - use firmware data for Cr-48

2012-07-20 Thread Chase Douglas
On 07/20/2012 02:03 AM, Daniel Kurtz wrote: * Leave the device as SEMI_MT, but provide the real locations, and allow userspace to determine the device vendor/model/etc. If userspace knows that a specific device behaves in a specific way, it can do its own quirking handling. Given the specificity

Re: [PATCH v2] Input: synaptics - use firmware data for Cr-48

2012-07-20 Thread Henrik Rydberg
> > Propagating information about various sensor defects to userspace > > sounds horrid to me. The sooner we can forget about these devices, the > > better. > > Not providing the userspace driver with enough information to give > users the best experience possible sounds horrid to me. The questio

Re: [PATCH v2] Input: synaptics - use firmware data for Cr-48

2012-07-20 Thread Daniel Kurtz
On Fri, Jul 20, 2012 at 3:25 PM, Henrik Rydberg wrote: > On Fri, Jul 20, 2012 at 11:14:25AM +0800, Chung-Yih Wang (王崇懿) wrote: >> From our experiments, the assumption of "the slowest corner is the >> stationary finger" is not always true. That is the major reason we want to >> report the firmware

Re: [PATCH v2] Input: synaptics - use firmware data for Cr-48

2012-07-20 Thread Henrik Rydberg
On Fri, Jul 20, 2012 at 11:14:25AM +0800, Chung-Yih Wang (王崇懿) wrote: > From our experiments, the assumption of "the slowest corner is the > stationary finger" is not always true. That is the major reason we want to > report the firmware data instead of semi-mt. Oh, but that was precisely the poin

Re: [PATCH v2] Input: synaptics - use firmware data for Cr-48

2012-07-19 Thread Henrik Rydberg
> I understand the usefulness of this functionality, but I also worry > about proliferating the number of properties for devices (there are > only 32 bits we can use, IIRC). I see four options off the top of my > head: > > * Don't do anything, leave it as SEMI_MT. Obviously this would suck, > but

Re: [PATCH v2] Input: synaptics - use firmware data for Cr-48

2012-07-19 Thread Chase Douglas
On 07/19/2012 10:05 AM, Daniel Kurtz wrote: On Fri, Jul 20, 2012 at 12:16 AM, Chase Douglas wrote: On 07/18/2012 08:02 PM, Chung-Yih Wang (王崇懿) wrote: Hi Chase, Thanks for your great comments. You are right, it is impossible to get correct finger tracking if both fingers are moving. H

Re: [PATCH v2] Input: synaptics - use firmware data for Cr-48

2012-07-19 Thread Daniel Kurtz
On Fri, Jul 20, 2012 at 12:16 AM, Chase Douglas wrote: > > On 07/18/2012 08:02 PM, Chung-Yih Wang (王崇懿) wrote: >> >> Hi Chase, >> >> Thanks for your great comments. You are right, it is impossible to >> get correct finger tracking if both fingers are moving. However, we >> think it still wort

Re: [PATCH v2] Input: synaptics - use firmware data for Cr-48

2012-07-19 Thread Chase Douglas
On 07/18/2012 08:02 PM, Chung-Yih Wang (王崇懿) wrote: Hi Chase, Thanks for your great comments. You are right, it is impossible to get correct finger tracking if both fingers are moving. However, we think it still worth to have the firmware tracking of the fingers as they could perform well f

Re: [PATCH v2] Input: synaptics - use firmware data for Cr-48

2012-07-19 Thread Henrik Rydberg
>Thanks for your great comments. You are right, it is impossible to get > correct finger tracking if both fingers are moving. However, we think it > still worth to have the firmware tracking of the fingers as they could > perform well for most one-stationary-one-moving cases. This will be good

Re: [PATCH v2] Input: synaptics - use firmware data for Cr-48

2012-07-18 Thread Dmitry Torokhov
Hi Chung-Yih, On Thu, Jul 19, 2012 at 11:02:23AM +0800, Chung-Yih Wang (王崇懿) wrote: > Hi Chase, > >Thanks for your great comments. You are right, it is impossible to get > correct finger tracking if both fingers are moving. However, we think it > still worth to have the firmware tracking of

Re: [PATCH v2] Input: synaptics - use firmware data for Cr-48

2012-07-18 Thread Chase Douglas
On 07/18/2012 03:22 AM, Chung-yih Wang wrote: The profile sensor clickpad in a Cr-48 Chromebook does a reasonable job of tracking individual fingers. This tracking isn't perfect, but, experiments show that it works better than just passing "semi-mt" data to userspace, and making userspace try to