Re: [PATCH v2] Extend pca9532 device tree support

2017-04-09 Thread Felix Brack
Hello Jacek, On 09.04.2017 14:37, Jacek Anaszewski wrote: > Hello Felix, > > On 04/07/2017 10:22 AM, Felix Brack wrote: >> Hello Jacek, >> >> On 06.04.2017 21:00, Jacek Anaszewski wrote: >>> Hi Pavel, >>> >>> On 04/06/2017 05:50 PM, Pavel Machek wrote: Hi! >> diff --git a/Documentat

Re: [PATCH v2] Extend pca9532 device tree support

2017-04-09 Thread Jacek Anaszewski
Hello Felix, On 04/07/2017 10:22 AM, Felix Brack wrote: > Hello Jacek, > > On 06.04.2017 21:00, Jacek Anaszewski wrote: >> Hi Pavel, >> >> On 04/06/2017 05:50 PM, Pavel Machek wrote: >>> Hi! >>> > diff --git a/Documentation/devicetree/bindings/leds/leds-pca9532.txt > b/Documentation/devi

default-state LED property (was Re: [PATCH v2] Extend pca9532 device tree support)

2017-04-07 Thread Pavel Machek
Hi! > >> This seems to look for "pwm0" and "pwm1" strings, which do not seem to > >> be documented. > >> > >> Plus... is it useful to have default-state? We already have default > >> trigger. If we keep the value by default (on PC, we do something like > >> that) this patch should not be neccessar

Re: [PATCH v2] Extend pca9532 device tree support

2017-04-07 Thread Felix Brack
Hello Jacek, On 06.04.2017 21:00, Jacek Anaszewski wrote: > Hi Pavel, > > On 04/06/2017 05:50 PM, Pavel Machek wrote: >> Hi! >> diff --git a/Documentation/devicetree/bindings/leds/leds-pca9532.txt b/Documentation/devicetree/bindings/leds/leds-pca9532.txt index 198f3ba..8374075 100

Re: [PATCH v2] Extend pca9532 device tree support

2017-04-06 Thread Jacek Anaszewski
Hi Pavel, On 04/06/2017 05:50 PM, Pavel Machek wrote: > Hi! > >>> diff --git a/Documentation/devicetree/bindings/leds/leds-pca9532.txt >>> b/Documentation/devicetree/bindings/leds/leds-pca9532.txt >>> index 198f3ba..8374075 100644 >>> --- a/Documentation/devicetree/bindings/leds/leds-pca9532.txt

Re: [PATCH v2] Extend pca9532 device tree support

2017-04-06 Thread Pavel Machek
Hi! > > diff --git a/Documentation/devicetree/bindings/leds/leds-pca9532.txt > > b/Documentation/devicetree/bindings/leds/leds-pca9532.txt > > index 198f3ba..8374075 100644 > > --- a/Documentation/devicetree/bindings/leds/leds-pca9532.txt > > +++ b/Documentation/devicetree/bindings/leds/leds-pca9

Re: [PATCH v2] Extend pca9532 device tree support

2017-04-02 Thread Jacek Anaszewski
Hi Felix, Thanks for the patch. I made a few cosmetic amendments to it, please refer below. On 03/30/2017 03:33 PM, Felix Brack wrote: > This patch extends the device tree support for the pca9532 by adding > the leds 'default-state' property. > Added leds: pca9532: prefix to the patch title.