On Sat, 2014-02-15 at 23:30 +0100, Pavel Machek wrote:
> Hi!
>
> > > >> > Firmware files are available for download from nemo project:
> > > >> >
> > > >> > https://api.merproject.org/public/source/nemo:devel:hw:ti:om
> > > >> > ap3:n900/bcm-bt-firmware/bcm-bt-firmware-0.21rc3.tar.bz2
> > > >> > h
Hi!
> > >> > Firmware files are available for download from nemo project:
> > >> >
> > >> > https://api.merproject.org/public/source/nemo:devel:hw:ti:om
> > >> > ap3:n900/bcm-bt-firmware/bcm-bt-firmware-0.21rc3.tar.bz2
> > >> > https://api.merproject.org/public/source/nemo:devel:hw:ti:o
> > >> > m
Hi Pali,
On Thu, Feb 13, 2014 at 04:33:28PM +0100, Pali Rohár wrote:
> 2014-01-08 22:36 GMT+01:00 Pali Rohár :
> > On Monday 30 December 2013 15:52:51 Sebastian Reichel wrote:
> >> > > > +MODULE_DESCRIPTION("Bluetooth h4 driver with nokia
> >> > > > extensions"); +MODULE_LICENSE("GPL");
> >> > > >
2014-01-08 22:36 GMT+01:00 Pali Rohár :
> On Monday 30 December 2013 15:52:51 Sebastian Reichel wrote:
>> > > > +MODULE_DESCRIPTION("Bluetooth h4 driver with nokia
>> > > > extensions"); +MODULE_LICENSE("GPL");
>> > > > +MODULE_AUTHOR("Ville Tervo");
>> > > > +MODULE_FIRMWARE(FW_NAME_TI1271_PRELE);
On Monday 30 December 2013 15:52:51 Sebastian Reichel wrote:
> > > > +MODULE_DESCRIPTION("Bluetooth h4 driver with nokia
> > > > extensions"); +MODULE_LICENSE("GPL");
> > > > +MODULE_AUTHOR("Ville Tervo");
> > > > +MODULE_FIRMWARE(FW_NAME_TI1271_PRELE);
> > > > +MODULE_FIRMWARE(FW_NAME_TI1271_LE);
Hi!
> >>> +static struct task_struct *h4p_thread;
> >>
> >> Can’t this be done using a work queue. You are looking at a 3.14
> >> kernel the earliest. We have way better primitives these days.
> >
> > I tried to convert it to work queue, but was not too
> > succesfull. Workqueue is not really go
Hi Pavel,
>>> +static struct task_struct *h4p_thread;
>>
>> Can’t this be done using a work queue. You are looking at a 3.14
>> kernel the earliest. We have way better primitives these days.
>
> I tried to convert it to work queue, but was not too
> succesfull. Workqueue is not really good match
Hi!
> > +static struct task_struct *h4p_thread;
>
> Can’t this be done using a work queue. You are looking at a 3.14
> kernel the earliest. We have way better primitives these days.
I tried to convert it to work queue, but was not too
succesfull. Workqueue is not really good match for what this
Hi again,
On Mon, Dec 30, 2013 at 03:52:51PM +0100, Sebastian Reichel wrote:
> On Mon, Dec 30, 2013 at 03:31:25PM +0100, Pali Rohár wrote:
> > [...] I think that correct commit message is not needed now.
> Wolfram Sang gave a talk about that at 30C3 yesterday. Official
> recordings of his talk ar
Hi!
> > +#define NBT_DBG(fmt, arg...) \
> > + pr_debug("%s: " fmt "" , __func__ , ## arg)
> > +
> > +#define NBT_DBG_FW(fmt, arg...) \
> > + pr_debug("%s: " fmt "" , __func__ , ## arg)
> > +
> > +#define NBT_DBG_POWER(fmt, arg...) \
> > + pr_debug("%s: " fmt "" , __fu
Hi!
> > +++ b/drivers/bluetooth/hci_h4p/core.c
> > @@ -0,0 +1,1357 @@
> > +/*
> > + * This file is part of hci_h4p bluetooth driver
> > + *
> > + * Copyright (C) 2005-2008 Nokia Corporation.
> > + *
> > + * Contact: Ville Tervo
>
> I think you can just remove the contact names since I think nobo
Hi!
> > +config BT_HCIH4P
> > + tristate "HCI driver with H4 Nokia extensions"
> > + depends on BT && ARCH_OMAP
>
> Since then we moved away from doing hci_* prefix of drivers since that is
> misleading. See btusb.ko, btmrvl_sdio.ko etc.
>
> So this might be better named BT_NOK_H4P or BT_NO
Hi,
On Mon, Dec 30, 2013 at 03:31:25PM +0100, Pali Rohár wrote:
> [...] I think that correct commit message is not needed now.
Please add patch descriptions as early as possible. Patches without
descriptions are anoying for misc. reasons. It's not too much work
to do and helps everyone to underst
On Saturday 28 December 2013 02:21:23 Marcel Holtmann wrote:
> Hi Pali,
>
> > I'm sending updated version of hci_h4p bluetooth driver. It
> > is needed for Nokia N900 bluetooth hardware. This (v2) is
> > older version of hci_h4p driver, but I tested it with
> > v3.13-rc3 kernel on Nokia N900 and w
On Monday 30 December 2013 14:19:44 Sebastian Reichel wrote:
> Hi,
>
> On Mon, Dec 30, 2013 at 01:13:50PM +0100, Pavel Machek wrote:
> > [...]
> >
> > Well, I can rename config option, but renaming the module
> > would break existing userland, no?
>
> Why is the userland depending on the module
On Monday 30 December 2013 13:13:50 Pavel Machek wrote:
> > > +
> > > + if (not_valid) {
> > > + dev_info(info->dev, "Valid bluetooth address not
found,
> > > setting some random\n"); +/* When address is not valid,
> > > use some random but Nokia MAC */ +mem
Hi,
On Mon, Dec 30, 2013 at 01:13:50PM +0100, Pavel Machek wrote:
> [...]
>
> Well, I can rename config option, but renaming the module would break
> existing userland, no?
Why is the userland depending on the module name?
> > Can we also make this just depend on some device tree information
>
Hi!
> > > @@ -0,0 +1,1357 @@
> > > +/*
> > > + * This file is part of hci_h4p bluetooth driver
> > > + *
> > > + * Copyright (C) 2005-2008 Nokia Corporation.
> > > + *
> > > + * Contact: Ville Tervo
> >
> > I think you can just remove the contact names since I think nobody of the
> > original a
Hi!
> > @@ -242,4 +242,14 @@ config BT_WILINK
> >
> > Say Y here to compile support for Texas Instrument's WiLink7 driver
> > into the kernel or say M to compile it as module.
> > +
> > +config BT_HCIH4P
> > + tristate "HCI driver with H4 Nokia extensions"
> > + depends on BT && A
On Friday 27 December 2013 12:02:47 Pali Rohár wrote:
> I'm sending updated version of hci_h4p bluetooth driver. It is needed for
> Nokia N900 bluetooth hardware. This (v2) is older version of hci_h4p driver,
> but I tested it with v3.13-rc3 kernel on Nokia N900 and working without any
> problems.
20 matches
Mail list logo