Re: [PATCH v18 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2015-01-06 Thread Russell King - ARM Linux
On Thu, Dec 11, 2014 at 12:24:15PM +0100, Heiko Stübner wrote: > Past practices suggest that having the dw in the name is a sane solution too, > like in dw_mmc-foo (mmc/host), dwmac-foo (net/ethernet/stmicro/stmmac). > > And personally I'd keep to this already established naming scheme ... i.e.

Re: [PATCH v18 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-12-11 Thread Heiko Stübner
Hi Daniel, Am Mittwoch, 10. Dezember 2014, 20:36:17 schrieb Daniel Kurtz: > This driver adds HDMI to rockchip/drm. The fact that rockchip's hdmi > uses dw_hdmi is an implementation detail. I do not think that the names > used for rk3288-hdmi should include "dw" in them. > > See inline for what

Re: [PATCH v18 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-12-10 Thread Daniel Kurtz
Hi Andy, This driver adds HDMI to rockchip/drm. The fact that rockchip's hdmi uses dw_hdmi is an implementation detail. I do not think that the names used for rk3288-hdmi should include "dw" in them. See inline for what I mean... On Thu, Dec 4, 2014 at 10:34 PM, Andy Yan wrote: > Rockchip RK3