Re: [PATCH v16 2/6] ring-buffer: Introducing ring-buffer mapping functions

2024-02-12 Thread Steven Rostedt
On Mon, 12 Feb 2024 10:44:26 + Vincent Donnefort wrote: > > > static void > > > rb_reset_cpu(struct ring_buffer_per_cpu *cpu_buffer) > > > { > > > @@ -5204,6 +5227,9 @@ rb_reset_cpu(struct ring_buffer_per_cpu *cpu_buffer) > > > cpu_buffer->lost_events = 0; > > > cpu_buffer->last_overru

Re: [PATCH v16 2/6] ring-buffer: Introducing ring-buffer mapping functions

2024-02-12 Thread Vincent Donnefort
[...] > > +static void rb_update_meta_page(struct ring_buffer_per_cpu *cpu_buffer) > > +{ > > + struct trace_buffer_meta *meta = cpu_buffer->meta_page; > > + > > + meta->reader.read = cpu_buffer->reader_page->read; > > + meta->reader.id = cpu_buffer->reader_page->id; > > + meta->reader.los

Re: [PATCH v16 2/6] ring-buffer: Introducing ring-buffer mapping functions

2024-02-11 Thread Steven Rostedt
On Fri, 9 Feb 2024 16:34:44 + Vincent Donnefort wrote: I have some comment updates, but I also notice a need to change the code slightly. Nothing major, but enough to perhaps have a v17. > > diff --git a/include/linux/ring_buffer.h b/include/linux/ring_buffer.h > index fa802db216f9..0841ba