Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-10-10 Thread Jassi Brar
On 11 October 2016 at 08:10, Horng-Shyang Liao wrote: > On Thu, 2016-10-06 at 18:40 +0530, Jassi Brar wrote: >> On 6 October 2016 at 18:31, Horng-Shyang Liao wrote: >> >> > Back to our original statement, we need to flush all tasks to queue >> > in GCE HW; i.e. we need to use mbox_client_txdone a

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-10-10 Thread Horng-Shyang Liao
On Thu, 2016-10-06 at 18:40 +0530, Jassi Brar wrote: > On 6 October 2016 at 18:31, Horng-Shyang Liao wrote: > > > Back to our original statement, we need to flush all tasks to queue > > in GCE HW; i.e. we need to use mbox_client_txdone after > > mbox_send_message, or send tx_done once mailbox con

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-10-06 Thread Jassi Brar
On 6 October 2016 at 18:31, Horng-Shyang Liao wrote: > Back to our original statement, we need to flush all tasks to queue > in GCE HW; i.e. we need to use mbox_client_txdone after > mbox_send_message, or send tx_done once mailbox controller receive > message (task). However, we still need a way

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-10-06 Thread Horng-Shyang Liao
On Wed, 2016-10-05 at 20:13 +0530, Jassi Brar wrote: > On 5 October 2016 at 18:01, Horng-Shyang Liao wrote: > > On Wed, 2016-10-05 at 09:07 +0530, Jassi Brar wrote: > >> On 5 October 2016 at 08:24, Horng-Shyang Liao wrote: > >> > On Fri, 2016-09-30 at 17:47 +0800, Horng-Shyang Liao wrote: > >> >>

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-10-05 Thread Jassi Brar
On 5 October 2016 at 18:01, Horng-Shyang Liao wrote: > On Wed, 2016-10-05 at 09:07 +0530, Jassi Brar wrote: >> On 5 October 2016 at 08:24, Horng-Shyang Liao wrote: >> > On Fri, 2016-09-30 at 17:47 +0800, Horng-Shyang Liao wrote: >> >> On Fri, 2016-09-30 at 17:11 +0800, CK Hu wrote: >> >> > >> > A

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-10-05 Thread Horng-Shyang Liao
On Wed, 2016-10-05 at 09:07 +0530, Jassi Brar wrote: > On 5 October 2016 at 08:24, Horng-Shyang Liao wrote: > > On Fri, 2016-09-30 at 17:47 +0800, Horng-Shyang Liao wrote: > >> On Fri, 2016-09-30 at 17:11 +0800, CK Hu wrote: > > > > > After I trace mailbox driver, I realize that CMDQ driver canno

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-10-04 Thread Jassi Brar
On 5 October 2016 at 08:24, Horng-Shyang Liao wrote: > On Fri, 2016-09-30 at 17:47 +0800, Horng-Shyang Liao wrote: >> On Fri, 2016-09-30 at 17:11 +0800, CK Hu wrote: > > After I trace mailbox driver, I realize that CMDQ driver cannot use > tx_done. > > CMDQ clients will flush many tasks into CMDQ

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-10-04 Thread Horng-Shyang Liao
On Fri, 2016-09-30 at 17:47 +0800, Horng-Shyang Liao wrote: > On Fri, 2016-09-30 at 17:11 +0800, CK Hu wrote: > > Hi, HS: > > > > One comment inline > > > > On Fri, 2016-09-30 at 16:56 +0800, Horng-Shyang Liao wrote: > > > Hi CK, > > > > > > Please see my inline reply. > > > > > > On Fri, 2016-

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-09-30 Thread Horng-Shyang Liao
On Fri, 2016-09-30 at 17:11 +0800, CK Hu wrote: > Hi, HS: > > One comment inline > > On Fri, 2016-09-30 at 16:56 +0800, Horng-Shyang Liao wrote: > > Hi CK, > > > > Please see my inline reply. > > > > On Fri, 2016-09-30 at 11:06 +0800, CK Hu wrote: > > > Hi, HS: > > > > > > On Mon, 2016-09-05 a

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-09-30 Thread CK Hu
Hi, HS: One comment inline On Fri, 2016-09-30 at 16:56 +0800, Horng-Shyang Liao wrote: > Hi CK, > > Please see my inline reply. > > On Fri, 2016-09-30 at 11:06 +0800, CK Hu wrote: > > Hi, HS: > > > > On Mon, 2016-09-05 at 09:44 +0800, HS Liao wrote: > > > This patch is first version of Mediate

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-09-30 Thread Horng-Shyang Liao
Hi CK, Please see my inline reply. On Fri, 2016-09-30 at 11:06 +0800, CK Hu wrote: > Hi, HS: > > On Mon, 2016-09-05 at 09:44 +0800, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help write registers with critical time limitation, >

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-09-30 Thread Horng-Shyang Liao
On Fri, 2016-09-23 at 17:28 +0800, Horng-Shyang Liao wrote: > Hi Jassi, > > Please see my inline reply. > > On Thu, 2016-09-22 at 13:47 +0530, Jassi Brar wrote: > > On Mon, Sep 5, 2016 at 7:14 AM, HS Liao wrote: > [...] > > > +struct cmdq_base *cmdq_register_device(struct device *dev) > > > +{ >

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-09-29 Thread CK Hu
Hi, HS: On Mon, 2016-09-05 at 09:44 +0800, HS Liao wrote: > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > CMDQ is used to help write registers with critical time limitation, > such as updating display configuration during the vblank. It controls > Global Command Engine

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-09-23 Thread Horng-Shyang Liao
Hi Jassi, Please see my inline reply. On Thu, 2016-09-22 at 13:47 +0530, Jassi Brar wrote: > On Mon, Sep 5, 2016 at 7:14 AM, HS Liao wrote: [...] > > +struct cmdq_base *cmdq_register_device(struct device *dev) > > +{ > > + struct cmdq_base *cmdq_base; > > + struct resource res; > > +

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

2016-09-22 Thread Jassi Brar
On Mon, Sep 5, 2016 at 7:14 AM, HS Liao wrote: > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > CMDQ is used to help write registers with critical time limitation, > such as updating display configuration during the vblank. It controls > Global Command Engine (GCE) hardw