Re: [PATCH v13 04/13] x86/sgx: Architectural structures

2018-09-05 Thread Jarkko Sakkinen
On Tue, Sep 04, 2018 at 09:04:44AM -0700, Dave Hansen wrote: > On 09/03/2018 06:16 AM, Andy Shevchenko wrote: > >> + EBLOCK = 0x9, > >> + EPA = 0xA, > >> + EWB = 0xB, > >> + ETRACK = 0xC, > >> + EAUG= 0xD, > >> + EMODPR = 0xE, > >> + EMODT

Re: [PATCH v13 04/13] x86/sgx: Architectural structures

2018-09-04 Thread Andy Shevchenko
On Tue, Sep 4, 2018 at 7:04 PM Dave Hansen wrote: > > On 09/03/2018 06:16 AM, Andy Shevchenko wrote: > >> + EBLOCK = 0x9, > >> + EPA = 0xA, > >> + EWB = 0xB, > >> + ETRACK = 0xC, > >> + EAUG= 0xD, > >> + EMODPR = 0xE, > >> + EMODT = 0xF, >

Re: [PATCH v13 04/13] x86/sgx: Architectural structures

2018-09-04 Thread Dave Hansen
On 09/03/2018 06:16 AM, Andy Shevchenko wrote: >> + EBLOCK = 0x9, >> + EPA = 0xA, >> + EWB = 0xB, >> + ETRACK = 0xC, >> + EAUG= 0xD, >> + EMODPR = 0xE, >> + EMODT = 0xF, >> +}; > Hmm... This E prefix confuses me with (system wide) error cod

Re: [PATCH v13 04/13] x86/sgx: Architectural structures

2018-09-03 Thread Jarkko Sakkinen
On Mon, Sep 03, 2018 at 04:16:42PM +0300, Andy Shevchenko wrote: > On Mon, Aug 27, 2018 at 9:57 PM Jarkko Sakkinen > wrote: > > > > Add arch/x86/include/asm/sgx_arch.h, which contains definitions for the > > architectural data structures used by the CPU to implement the SGX. > > > +/** > > + * en

Re: [PATCH v13 04/13] x86/sgx: Architectural structures

2018-09-03 Thread Andy Shevchenko
On Mon, Aug 27, 2018 at 9:57 PM Jarkko Sakkinen wrote: > > Add arch/x86/include/asm/sgx_arch.h, which contains definitions for the > architectural data structures used by the CPU to implement the SGX. > +/** > + * enum sgx_encls_leaves - ENCLS leaf functions > + * %ECREATE: Create an enclave. >

Re: [PATCH v13 04/13] x86/sgx: Architectural structures

2018-08-28 Thread Jarkko Sakkinen
On Mon, Aug 27, 2018 at 12:41:29PM -0700, Dave Hansen wrote: > > +/** > > + * enum sgx_encls_leaves - return codes for ENCLS, ENCLU and ENCLV > > + * %SGX_SUCCESS: No error. > > + * %SGX_INVALID_SIG_STRUCT:SIGSTRUCT contains an invalid value. > > + * %SGX_INVALID_ATTRIBUTE: Enclav

Re: [PATCH v13 04/13] x86/sgx: Architectural structures

2018-08-27 Thread Dave Hansen
> +/** > + * enum sgx_encls_leaves - return codes for ENCLS, ENCLU and ENCLV > + * %SGX_SUCCESS: No error. > + * %SGX_INVALID_SIG_STRUCT: SIGSTRUCT contains an invalid value. > + * %SGX_INVALID_ATTRIBUTE: Enclave is not attempting to access a resource > + *