Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-20 Thread William Breathitt Gray
On Fri, Nov 20, 2020 at 02:26:35PM +0100, Arnd Bergmann wrote: > On Fri, Nov 13, 2020 at 5:52 PM Syed Nayyar Waris > wrote: > > On Wed, Nov 11, 2020 at 3:30 AM Syed Nayyar Waris > > wrote: > > > On Tue, Nov 10, 2020 at 12:43:16PM -0500, William Breathitt Gray wrote: > > > > On Tue, Nov 10, 2020

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-20 Thread Arnd Bergmann
On Fri, Nov 13, 2020 at 5:52 PM Syed Nayyar Waris wrote: > On Wed, Nov 11, 2020 at 3:30 AM Syed Nayyar Waris > wrote: > > On Tue, Nov 10, 2020 at 12:43:16PM -0500, William Breathitt Gray wrote: > > > On Tue, Nov 10, 2020 at 10:52:42PM +0530, Syed Nayyar Waris wrote: > > > > On Tue, Nov 10, 2020

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-13 Thread Syed Nayyar Waris
On Wed, Nov 11, 2020 at 3:30 AM Syed Nayyar Waris wrote: > > On Tue, Nov 10, 2020 at 12:43:16PM -0500, William Breathitt Gray wrote: > > On Tue, Nov 10, 2020 at 10:52:42PM +0530, Syed Nayyar Waris wrote: > > > On Tue, Nov 10, 2020 at 6:05 PM William Breathitt Gray > > > wrote: > > > > > > > > On

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-10 Thread Syed Nayyar Waris
On Tue, Nov 10, 2020 at 12:43:16PM -0500, William Breathitt Gray wrote: > On Tue, Nov 10, 2020 at 10:52:42PM +0530, Syed Nayyar Waris wrote: > > On Tue, Nov 10, 2020 at 6:05 PM William Breathitt Gray > > wrote: > > > > > > On Tue, Nov 10, 2020 at 11:02:43AM +0100, Michal Simek wrote: > > > > > > >

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-10 Thread William Breathitt Gray
On Tue, Nov 10, 2020 at 10:52:42PM +0530, Syed Nayyar Waris wrote: > On Tue, Nov 10, 2020 at 6:05 PM William Breathitt Gray > wrote: > > > > On Tue, Nov 10, 2020 at 11:02:43AM +0100, Michal Simek wrote: > > > > > > > > > On 09. 11. 20 18:31, William Breathitt Gray wrote: > > > > On Mon, Nov 09, 20

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-10 Thread Syed Nayyar Waris
On Tue, Nov 10, 2020 at 6:05 PM William Breathitt Gray wrote: > > On Tue, Nov 10, 2020 at 11:02:43AM +0100, Michal Simek wrote: > > > > > > On 09. 11. 20 18:31, William Breathitt Gray wrote: > > > On Mon, Nov 09, 2020 at 07:22:20PM +0200, Andy Shevchenko wrote: > > >> On Mon, Nov 09, 2020 at 12:11

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-10 Thread William Breathitt Gray
On Tue, Nov 10, 2020 at 11:02:43AM +0100, Michal Simek wrote: > > > On 09. 11. 20 18:31, William Breathitt Gray wrote: > > On Mon, Nov 09, 2020 at 07:22:20PM +0200, Andy Shevchenko wrote: > >> On Mon, Nov 09, 2020 at 12:11:40PM -0500, William Breathitt Gray wrote: > >>> On Mon, Nov 09, 2020 at 10

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-10 Thread Michal Simek
On 09. 11. 20 18:31, William Breathitt Gray wrote: > On Mon, Nov 09, 2020 at 07:22:20PM +0200, Andy Shevchenko wrote: >> On Mon, Nov 09, 2020 at 12:11:40PM -0500, William Breathitt Gray wrote: >>> On Mon, Nov 09, 2020 at 10:15:29PM +0530, Syed Nayyar Waris wrote: On Mon, Nov 09, 2020 at 03:

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-09 Thread William Breathitt Gray
On Mon, Nov 09, 2020 at 07:22:20PM +0200, Andy Shevchenko wrote: > On Mon, Nov 09, 2020 at 12:11:40PM -0500, William Breathitt Gray wrote: > > On Mon, Nov 09, 2020 at 10:15:29PM +0530, Syed Nayyar Waris wrote: > > > On Mon, Nov 09, 2020 at 03:41:53PM +0100, Arnd Bergmann wrote: > > ... > > > > s

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-09 Thread Andy Shevchenko
On Mon, Nov 09, 2020 at 12:11:40PM -0500, William Breathitt Gray wrote: > On Mon, Nov 09, 2020 at 10:15:29PM +0530, Syed Nayyar Waris wrote: > > On Mon, Nov 09, 2020 at 03:41:53PM +0100, Arnd Bergmann wrote: ... > > static inline void bitmap_set_value(unsigned long *map, > > -

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-09 Thread William Breathitt Gray
On Mon, Nov 09, 2020 at 10:15:29PM +0530, Syed Nayyar Waris wrote: > On Mon, Nov 09, 2020 at 03:41:53PM +0100, Arnd Bergmann wrote: > > On Mon, Nov 9, 2020 at 2:41 PM William Breathitt Gray > > wrote: > > > On Mon, Nov 09, 2020 at 06:04:11PM +0530, Syed Nayyar Waris wrote: > > > > > > One of my co

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-09 Thread Syed Nayyar Waris
On Mon, Nov 09, 2020 at 03:41:53PM +0100, Arnd Bergmann wrote: > On Mon, Nov 9, 2020 at 2:41 PM William Breathitt Gray > wrote: > > On Mon, Nov 09, 2020 at 06:04:11PM +0530, Syed Nayyar Waris wrote: > > > > One of my concerns is that we're incurring the latency two additional > > conditional check

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-09 Thread William Breathitt Gray
On Mon, Nov 09, 2020 at 08:18:51PM +0530, Syed Nayyar Waris wrote: > On Mon, Nov 9, 2020 at 8:09 PM William Breathitt Gray > wrote: > > > > On Mon, Nov 09, 2020 at 08:41:28AM -0500, William Breathitt Gray wrote: > > > On Mon, Nov 09, 2020 at 06:04:11PM +0530, Syed Nayyar Waris wrote: > > > > On Su

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-09 Thread Syed Nayyar Waris
On Mon, Nov 9, 2020 at 8:09 PM William Breathitt Gray wrote: > > On Mon, Nov 09, 2020 at 08:41:28AM -0500, William Breathitt Gray wrote: > > On Mon, Nov 09, 2020 at 06:04:11PM +0530, Syed Nayyar Waris wrote: > > > On Sun, Nov 01, 2020 at 09:08:29PM +0100, Arnd Bergmann wrote: > > > > On Sun, Nov 1

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-09 Thread Arnd Bergmann
On Mon, Nov 9, 2020 at 2:41 PM William Breathitt Gray wrote: > On Mon, Nov 09, 2020 at 06:04:11PM +0530, Syed Nayyar Waris wrote: > > One of my concerns is that we're incurring the latency two additional > conditional checks just to suppress a compiler warning about a case that > wouldn't occur in

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-09 Thread William Breathitt Gray
On Mon, Nov 09, 2020 at 08:41:28AM -0500, William Breathitt Gray wrote: > On Mon, Nov 09, 2020 at 06:04:11PM +0530, Syed Nayyar Waris wrote: > > On Sun, Nov 01, 2020 at 09:08:29PM +0100, Arnd Bergmann wrote: > > > On Sun, Nov 1, 2020 at 4:00 PM William Breathitt Gray > > > wrote: > > > > > > > > O

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-09 Thread William Breathitt Gray
On Mon, Nov 09, 2020 at 06:04:11PM +0530, Syed Nayyar Waris wrote: > On Sun, Nov 01, 2020 at 09:08:29PM +0100, Arnd Bergmann wrote: > > On Sun, Nov 1, 2020 at 4:00 PM William Breathitt Gray > > wrote: > > > > > > On Thu, Oct 29, 2020 at 11:44:47PM +0100, Arnd Bergmann wrote: > > > > On Sun, Oct 18

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-09 Thread Arnd Bergmann
On Mon, Nov 9, 2020 at 1:34 PM Syed Nayyar Waris wrote: > On Sun, Nov 01, 2020 at 09:08:29PM +0100, Arnd Bergmann wrote: > > > This avoids adding a costly conditional check inside bitmap_set_value() > > > when almost all bitmap_set_value() calls will have static arguments with > > > well-defined a

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-09 Thread Syed Nayyar Waris
On Sun, Nov 01, 2020 at 09:08:29PM +0100, Arnd Bergmann wrote: > On Sun, Nov 1, 2020 at 4:00 PM William Breathitt Gray > wrote: > > > > On Thu, Oct 29, 2020 at 11:44:47PM +0100, Arnd Bergmann wrote: > > > On Sun, Oct 18, 2020 at 11:44 PM Syed Nayyar Waris > > > wrote: > > > > > > > > This patch

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-01 Thread Arnd Bergmann
On Sun, Nov 1, 2020 at 4:00 PM William Breathitt Gray wrote: > > On Thu, Oct 29, 2020 at 11:44:47PM +0100, Arnd Bergmann wrote: > > On Sun, Oct 18, 2020 at 11:44 PM Syed Nayyar Waris > > wrote: > > > > > > This patch reimplements the xgpio_set_multiple() function in > > > drivers/gpio/gpio-xilin

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-11-01 Thread William Breathitt Gray
On Thu, Oct 29, 2020 at 11:44:47PM +0100, Arnd Bergmann wrote: > On Sun, Oct 18, 2020 at 11:44 PM Syed Nayyar Waris > wrote: > > > > This patch reimplements the xgpio_set_multiple() function in > > drivers/gpio/gpio-xilinx.c to use the new generic functions: > > bitmap_get_value() and bitmap_set_

Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2020-10-29 Thread Arnd Bergmann
On Sun, Oct 18, 2020 at 11:44 PM Syed Nayyar Waris wrote: > > This patch reimplements the xgpio_set_multiple() function in > drivers/gpio/gpio-xilinx.c to use the new generic functions: > bitmap_get_value() and bitmap_set_value(). The code is now simpler > to read and understand. Moreover, instead