Re: [PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-19 Thread Daniel Vetter
On Wed, Nov 19, 2014 at 10:04:13AM +0100, Boris Brezillon wrote: > AFAIU, the suggestion was to split drm_connector_init and > drm_connector_register calls: > - drm_connector_init call should still be part of the load procedure >(this function adds the connector to the connector list which is

Re: [PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-19 Thread Boris Brezillon
On Wed, 19 Nov 2014 10:02:53 +0800 Mark yao wrote: > On 2014年11月19日 09:09, Mark yao wrote: > > On 2014年11月18日 22:24, Daniel Vetter wrote: > >> On Tue, Nov 18, 2014 at 02:21:30PM +0100, Boris Brezillon wrote: > >>> Hi Daniel, > >>> > >>> On Tue, 18 Nov 2014 09:32:34 +0100 > >>> Daniel Vetter wrot

Re: [PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-18 Thread Mark yao
On 2014年11月18日 22:24, Daniel Vetter wrote: On Tue, Nov 18, 2014 at 02:21:30PM +0100, Boris Brezillon wrote: Hi Daniel, On Tue, 18 Nov 2014 09:32:34 +0100 Daniel Vetter wrote: On Tue, Nov 18, 2014 at 04:00:29PM +0800, Mark Yao wrote: From: Mark yao This patch adds the basic structure of a

Re: [PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-18 Thread Daniel Vetter
On Tue, Nov 18, 2014 at 02:21:30PM +0100, Boris Brezillon wrote: > Hi Daniel, > > On Tue, 18 Nov 2014 09:32:34 +0100 > Daniel Vetter wrote: > > > On Tue, Nov 18, 2014 at 04:00:29PM +0800, Mark Yao wrote: > > > From: Mark yao > > > > > > This patch adds the basic structure of a DRM Driver for R

Re: [PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-18 Thread Boris Brezillon
Hi Daniel, On Tue, 18 Nov 2014 09:32:34 +0100 Daniel Vetter wrote: > On Tue, Nov 18, 2014 at 04:00:29PM +0800, Mark Yao wrote: > > From: Mark yao > > > > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > > > Signed-off-by: Mark Yao > > Signed-off-by: Daniel Kurtz >

Re: [PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-18 Thread Mark yao
On 2014年11月18日 16:32, Daniel Vetter wrote: On Tue, Nov 18, 2014 at 04:00:29PM +0800, Mark Yao wrote: From: Mark yao This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark Yao Signed-off-by: Daniel Kurtz Acked-by: Daniel Vetter Reviewed-by: Rob Clark ---

Re: [PATCH v12 1/3] drm: rockchip: Add basic drm driver

2014-11-18 Thread Daniel Vetter
On Tue, Nov 18, 2014 at 04:00:29PM +0800, Mark Yao wrote: > From: Mark yao > > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark Yao > Signed-off-by: Daniel Kurtz > Acked-by: Daniel Vetter > Reviewed-by: Rob Clark > --- > Changes in v2: > - use th