Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-02-15 Thread Andy Shevchenko
On Tue, Feb 2, 2021 at 3:52 AM Carlis wrote: > On Mon, 1 Feb 2021 19:40:21 +0200 > Andy Shevchenko wrote: > > > On Sat, Jan 30, 2021 at 8:39 AM carlis wrote: > > > On Fri, 29 Jan 2021 16:26:12 +0200 > > > Andy Shevchenko wrote: > > > > On Fri, Jan 29, 2021 at 3:56 PM carlis > > > > wrote: > >

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-02-01 Thread Carlis
On Mon, 1 Feb 2021 19:40:21 +0200 Andy Shevchenko wrote: > On Sat, Jan 30, 2021 at 8:39 AM carlis wrote: > > On Fri, 29 Jan 2021 16:26:12 +0200 > > Andy Shevchenko wrote: > > > On Fri, Jan 29, 2021 at 3:56 PM carlis > > > wrote: > > > > On Fri, 29 Jan 2021 12:23:08 +0200 > > > > Andy Shevc

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-02-01 Thread Andy Shevchenko
On Sat, Jan 30, 2021 at 8:39 AM carlis wrote: > On Fri, 29 Jan 2021 16:26:12 +0200 > Andy Shevchenko wrote: > > On Fri, Jan 29, 2021 at 3:56 PM carlis wrote: > > > On Fri, 29 Jan 2021 12:23:08 +0200 > > > Andy Shevchenko wrote: ... > > > Hi, I apologize for what I said in the previous two ema

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-01-30 Thread carlis
On Fri, 29 Jan 2021 16:26:12 +0200 Andy Shevchenko wrote: > On Fri, Jan 29, 2021 at 3:56 PM carlis wrote: > > On Fri, 29 Jan 2021 12:23:08 +0200 > > Andy Shevchenko wrote: > > We are almost there, I have no idea what Noralf or others are going to > say though. > > ... > > > Hi, I apologize

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-01-28 Thread carlis
On Thu, 28 Jan 2021 16:33:02 +0200 Andy Shevchenko wrote: > On Thu, Jan 28, 2021 at 2:58 PM Carlis wrote: > > Thanks for your contribution, my comments below. > > > From: zhangxuezhi > > You probably have to configure your Git to use the same account for > author and committer. hi,you mea

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-01-28 Thread Dan Carpenter
On Thu, Jan 28, 2021 at 04:33:02PM +0200, Andy Shevchenko wrote: > > + init_completion(&spi_panel_te); > > + rc = devm_request_irq(dev, > > > + gpiod_to_irq(par->gpio.te), > > ...and here simply use irq. > > > +

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 4:33 PM Andy Shevchenko wrote: > On Thu, Jan 28, 2021 at 2:58 PM Carlis wrote: ... > Taking all together you probably need to create a helper and use it > inside init_display(), like > > static int init_tearing_effect_line(struct fbtft_par *par) > { > struct device *de

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 2:58 PM Carlis wrote: Thanks for your contribution, my comments below. > From: zhangxuezhi You probably have to configure your Git to use the same account for author and committer. > For st7789v ic,when we need continuous full screen refresh, it is best to 'ic,when' -

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-01-28 Thread Greg KH
On Thu, Jan 28, 2021 at 08:53:55PM +0800, Carlis wrote: > From: zhangxuezhi > > For st7789v ic,when we need continuous full screen refresh, it is best to > wait for the TE signal arrive to avoid screen tearing > > Signed-off-by: zhangxuezhi > --- > v12: change dev_err to dev_err_probe and add s