Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-04 Thread Lee Jones
On Thu, 04 Apr 2019, Vaittinen, Matti wrote: > Hello Alexandre, > > On Thu, 2019-04-04 at 09:56 +0200, Alexandre Belloni wrote: > > On 04/04/2019 10:24:49+0300, Matti Vaittinen wrote: > > > On Thu, Apr 04, 2019 at 07:54:52AM +0100, Lee Jones wrote: > > > > On Thu, 04 Apr 2019, Vaittinen, Matti wr

Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-04 Thread Vaittinen, Matti
Hello Alexandre, On Thu, 2019-04-04 at 09:56 +0200, Alexandre Belloni wrote: > On 04/04/2019 10:24:49+0300, Matti Vaittinen wrote: > > On Thu, Apr 04, 2019 at 07:54:52AM +0100, Lee Jones wrote: > > > On Thu, 04 Apr 2019, Vaittinen, Matti wrote: > > > > > > > Actually, now that I thik of it the ri

Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-04 Thread Lee Jones
> > > ROHM. Also, I am not terribly excited about the option of changing this > > > back to function-pointer as I already removed the pointer from parent > > > data and this changed parent data is already adapted to all sub drivers > > > - so this is all just babbling. Maybe it is just my huge ego

Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-04 Thread Alexandre Belloni
On 04/04/2019 10:24:49+0300, Matti Vaittinen wrote: > On Thu, Apr 04, 2019 at 07:54:52AM +0100, Lee Jones wrote: > > On Thu, 04 Apr 2019, Vaittinen, Matti wrote: > > > > > Actually, now that I thik of it the right way to do this would have > > > been the function pointer in parent data as was done

Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-04 Thread Matti Vaittinen
On Thu, Apr 04, 2019 at 07:54:52AM +0100, Lee Jones wrote: > On Thu, 04 Apr 2019, Vaittinen, Matti wrote: > > > Actually, now that I thik of it the right way to do this would have > > been the function pointer in parent data as was done in original patch > > set. HW-colleagues tend to re-use HW bl

Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-03 Thread Lee Jones
On Thu, 04 Apr 2019, Vaittinen, Matti wrote: > On Thu, 2019-04-04 at 03:52 +0100, Lee Jones wrote: > > On Wed, 03 Apr 2019, Vaittinen, Matti wrote: > > > > > On Wed, 2019-04-03 at 12:25 +0100, Lee Jones wrote: > > > > On Wed, 03 Apr 2019, Matti Vaittinen wrote: > > > > > > > > > On Wed, Apr 03,

Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-03 Thread Vaittinen, Matti
On Thu, 2019-04-04 at 03:52 +0100, Lee Jones wrote: > On Wed, 03 Apr 2019, Vaittinen, Matti wrote: > > > On Wed, 2019-04-03 at 12:25 +0100, Lee Jones wrote: > > > On Wed, 03 Apr 2019, Matti Vaittinen wrote: > > > > > > > On Wed, Apr 03, 2019 at 10:30:15AM +0100, Lee Jones wrote: > > > > > On Wed,

Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-03 Thread Lee Jones
On Wed, 03 Apr 2019, Vaittinen, Matti wrote: > On Wed, 2019-04-03 at 12:25 +0100, Lee Jones wrote: > > On Wed, 03 Apr 2019, Matti Vaittinen wrote: > > > > > On Wed, Apr 03, 2019 at 10:30:15AM +0100, Lee Jones wrote: > > > > On Wed, 03 Apr 2019, Matti Vaittinen wrote: > > > > > > > > > Hello Lee,

Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-03 Thread Vaittinen, Matti
On Wed, 2019-04-03 at 12:25 +0100, Lee Jones wrote: > On Wed, 03 Apr 2019, Matti Vaittinen wrote: > > > On Wed, Apr 03, 2019 at 10:30:15AM +0100, Lee Jones wrote: > > > On Wed, 03 Apr 2019, Matti Vaittinen wrote: > > > > > > > Hello Lee, > > > > > > > > Thanks for taking a look on this again =)

Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-03 Thread Lee Jones
On Wed, 03 Apr 2019, Matti Vaittinen wrote: > On Wed, Apr 03, 2019 at 10:30:15AM +0100, Lee Jones wrote: > > On Wed, 03 Apr 2019, Matti Vaittinen wrote: > > > > > Hello Lee, > > > > > > Thanks for taking a look on this again =) I agree with most of the > > > comments and correct them at next ver

Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-03 Thread Matti Vaittinen
On Wed, Apr 03, 2019 at 10:30:15AM +0100, Lee Jones wrote: > On Wed, 03 Apr 2019, Matti Vaittinen wrote: > > > Hello Lee, > > > > Thanks for taking a look on this again =) I agree with most of the > > comments and correct them at next version. > > > > On Wed, Apr 03, 2019 at 08:31:52AM +0100, Le

Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-03 Thread Lee Jones
On Wed, 03 Apr 2019, Matti Vaittinen wrote: > Hello Lee, > > Thanks for taking a look on this again =) I agree with most of the > comments and correct them at next version. > > On Wed, Apr 03, 2019 at 08:31:52AM +0100, Lee Jones wrote: > > On Mon, 25 Mar 2019, Matti Vaittinen wrote: > > > > > R

Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-03 Thread Matti Vaittinen
Hello Lee, Thanks for taking a look on this again =) I agree with most of the comments and correct them at next version. On Wed, Apr 03, 2019 at 08:31:52AM +0100, Lee Jones wrote: > On Mon, 25 Mar 2019, Matti Vaittinen wrote: > > > ROHM BD70528MWV is an ultra-low quiescent current general > > pu

Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-03 Thread Lee Jones
On Mon, 25 Mar 2019, Matti Vaittinen wrote: > ROHM BD70528MWV is an ultra-low quiescent current general > purpose single-chip power management IC for battery-powered > portable devices. > > Add MFD core which enables chip access for following subdevices: > - regulators/LED drivers > -