Re: [PATCH v10 5/7] i2c: fsi: Add transfer implementation

2018-07-05 Thread Wolfram Sang
> I meant that the hardware cannot interpret this, it would be a meaningless > command unfortunately. I see. Thanks for double-checking. signature.asc Description: PGP signature

Re: [PATCH v10 5/7] i2c: fsi: Add transfer implementation

2018-07-05 Thread Eddie James
On 07/02/2018 01:24 PM, Wolfram Sang wrote: + if (msg->flags & I2C_M_RD) + cmd |= I2C_CMD_READ; Since you support MANGLING, I'd think you can easily support I2C_M_REV_DIR_ADDR here, too? Hm, I don't really understand the purpose of that flag. From the docs: This toggles

Re: [PATCH v10 5/7] i2c: fsi: Add transfer implementation

2018-07-02 Thread Wolfram Sang
> > > + if (msg->flags & I2C_M_RD) > > > + cmd |= I2C_CMD_READ; > > Since you support MANGLING, I'd think you can easily support > > I2C_M_REV_DIR_ADDR here, too? > > Hm, I don't really understand the purpose of that flag. From the docs: > > This toggles the Rd/Wr flag. That is, if you w

Re: [PATCH v10 5/7] i2c: fsi: Add transfer implementation

2018-06-27 Thread Eddie James
On 06/25/2018 09:38 PM, Wolfram Sang wrote: On Wed, Jun 13, 2018 at 02:36:17PM -0500, Eddie James wrote: Execute I2C transfers from the FSI-attached I2C master. Use polling instead of interrupts as we have no hardware IRQ over FSI. Signed-off-by: Eddie James --- drivers/i2c/busses/i2c-fsi

Re: [PATCH v10 5/7] i2c: fsi: Add transfer implementation

2018-06-25 Thread Wolfram Sang
On Wed, Jun 13, 2018 at 02:36:17PM -0500, Eddie James wrote: > Execute I2C transfers from the FSI-attached I2C master. Use polling > instead of interrupts as we have no hardware IRQ over FSI. > > Signed-off-by: Eddie James > --- > drivers/i2c/busses/i2c-fsi.c | 195 > +++