Re: [PATCH v10 4/7] i2c: fsi: Add abort and hardware reset procedures

2018-07-05 Thread Wolfram Sang
Eddie, > Thanks for the details. I have sent up a new series which will only do the > bus reset if SDA is low. With our current hardware configuration, this Thanks. > *should* be sufficient to recover all the possible errors. However, there > are configurations where it will not be enough, in wh

Re: [PATCH v10 4/7] i2c: fsi: Add abort and hardware reset procedures

2018-07-05 Thread Eddie James
On 07/02/2018 01:15 PM, Wolfram Sang wrote: Hi Eddie, I think this is a way too aggressive recovery. Your are doing the 9 pulse toggles basically on any error while this is only when the device keeps SDA low and you want to recover from that. If SDA is not stuck low, sending a STOP should do

Re: [PATCH v10 4/7] i2c: fsi: Add abort and hardware reset procedures

2018-07-02 Thread Wolfram Sang
Hi Eddie, > > I think this is a way too aggressive recovery. Your are doing the 9 > > pulse toggles basically on any error while this is only when the device > > keeps SDA low and you want to recover from that. If SDA is not stuck > > low, sending a STOP should do. Or do you have a known case wher

Re: [PATCH v10 4/7] i2c: fsi: Add abort and hardware reset procedures

2018-06-27 Thread Eddie James
On 06/25/2018 09:38 PM, Wolfram Sang wrote: On Wed, Jun 13, 2018 at 02:36:16PM -0500, Eddie James wrote: Add abort procedure for failed transfers. Add engine and bus reset procedures to recover from as many faults as possible. I think this is a way too aggressive recovery. Your are doing the

Re: [PATCH v10 4/7] i2c: fsi: Add abort and hardware reset procedures

2018-06-25 Thread Wolfram Sang
On Wed, Jun 13, 2018 at 02:36:16PM -0500, Eddie James wrote: > Add abort procedure for failed transfers. Add engine and bus reset > procedures to recover from as many faults as possible. I think this is a way too aggressive recovery. Your are doing the 9 pulse toggles basically on any error while