Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.

2017-06-09 Thread Peter Rosin
On 2017-06-09 10:38, Andy Shevchenko wrote: > On Fri, 2017-06-09 at 07:12 +0200, Peter Rosin wrote: >> On 2017-06-08 19:36, Luis Oliveira wrote: >>> @@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev) >>> } >>> >>> i2c_dw_disable_int(dev); >>> - r = devm_request_irq(dev->dev,

Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.

2017-06-09 Thread Andy Shevchenko
On Fri, 2017-06-09 at 07:12 +0200, Peter Rosin wrote: > On 2017-06-08 19:36, Luis Oliveira wrote: > > complicated to review. The work here won't bring any additional work > > to > > backported fixes because is just style and reordering. > > I challenge that. If there is an old bug that existed bef

Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.

2017-06-09 Thread Luis Oliveira
On 09-Jun-17 6:12, Peter Rosin wrote: > On 2017-06-08 19:36, Luis Oliveira wrote: >> complicated to review. The work here won't bring any additional work to >> backported fixes because is just style and reordering. > > I challenge that. If there is an old bug that existed before this patch > that

Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.

2017-06-08 Thread Peter Rosin
On 2017-06-08 19:36, Luis Oliveira wrote: > complicated to review. The work here won't bring any additional work to > backported fixes because is just style and reordering. I challenge that. If there is an old bug that existed before this patch that is fixed in the future after this patch has been