Re: [PATCH v1 5/7] modpost: Create modalias for builtin modules

2025-05-03 Thread Petr Pavlu
On 4/29/25 17:15, Alexey Gladkov wrote: > On Tue, Apr 29, 2025 at 04:14:13PM +0200, Petr Pavlu wrote: >> On 4/29/25 14:49, Alexey Gladkov wrote: >>> On Tue, Apr 29, 2025 at 12:04:44PM +0200, Alexey Gladkov wrote: > I'm not sure it's best to overload this data in this way. I think mixing > a

Re: [PATCH v1 5/7] modpost: Create modalias for builtin modules

2025-04-29 Thread Alexey Gladkov
On Tue, Apr 29, 2025 at 04:14:13PM +0200, Petr Pavlu wrote: > On 4/29/25 14:49, Alexey Gladkov wrote: > > On Tue, Apr 29, 2025 at 12:04:44PM +0200, Alexey Gladkov wrote: > >>> I'm not sure it's best to overload this data in this way. I think mixing > >>> actual files and "logical" modules in the mo

Re: [PATCH v1 5/7] modpost: Create modalias for builtin modules

2025-04-29 Thread Petr Pavlu
On 4/29/25 14:49, Alexey Gladkov wrote: > On Tue, Apr 29, 2025 at 12:04:44PM +0200, Alexey Gladkov wrote: >>> I'm not sure it's best to overload this data in this way. I think mixing >>> actual files and "logical" modules in the modules list is somewhat >>> confusing. >>> >>> An alternative would b

Re: [PATCH v1 5/7] modpost: Create modalias for builtin modules

2025-04-29 Thread Alexey Gladkov
On Tue, Apr 29, 2025 at 12:04:44PM +0200, Alexey Gladkov wrote: > > I'm not sure it's best to overload this data in this way. I think mixing > > actual files and "logical" modules in the modules list is somewhat > > confusing. > > > > An alternative would be to keep a single module struct for vmli

Re: [PATCH v1 5/7] modpost: Create modalias for builtin modules

2025-04-29 Thread Alexey Gladkov
On Tue, Apr 29, 2025 at 11:25:47AM +0200, Petr Pavlu wrote: > On 4/26/25 18:16, Alexey Gladkov wrote: > > For some modules, modalias is generated using the modpost utility and > > the section is added to the module file. > > > > When a module is added inside vmlinux, modpost does not generate > >

Re: [PATCH v1 5/7] modpost: Create modalias for builtin modules

2025-04-29 Thread Petr Pavlu
On 4/26/25 18:16, Alexey Gladkov wrote: > For some modules, modalias is generated using the modpost utility and > the section is added to the module file. > > When a module is added inside vmlinux, modpost does not generate > modalias for such modules and the information is lost. > > As a result