Re: [PATCH v1 1/2] PCI: Document patch submission hints

2018-07-30 Thread Bjorn Helgaas
On Mon, Jul 30, 2018 at 04:31:36PM +0200, Lukas Wunner wrote: > On Thu, Jul 12, 2018 at 10:59:46AM -0500, Bjorn Helgaas wrote: > > But on reflection, I think the overall value of this writeup is > > minimal. It's a lot of repetition of things already documented > > elsewhere and most of it boils d

Re: [PATCH v1 1/2] PCI: Document patch submission hints

2018-07-30 Thread Lukas Wunner
On Thu, Jul 12, 2018 at 10:59:46AM -0500, Bjorn Helgaas wrote: > But on reflection, I think the overall value of this writeup is > minimal. It's a lot of repetition of things already documented > elsewhere and most of it boils down to "pay attention to existing > practice and don't do things diffe

Re: [PATCH v1 1/2] PCI: Document patch submission hints

2018-07-12 Thread Bjorn Helgaas
On Sun, Jul 01, 2018 at 07:45:08PM +0200, Lukas Wunner wrote: > On Fri, Jun 29, 2018 at 03:27:39PM -0500, Bjorn Helgaas wrote: > > --- /dev/null > > +++ b/Documentation/PCI/submitting-patches.txt > > @@ -0,0 +1,153 @@ > > +Start with Documentation/process/submitting-patches.rst for general > > +gui

Re: [PATCH v1 1/2] PCI: Document patch submission hints

2018-07-01 Thread Lukas Wunner
On Fri, Jun 29, 2018 at 03:27:39PM -0500, Bjorn Helgaas wrote: > --- /dev/null > +++ b/Documentation/PCI/submitting-patches.txt > @@ -0,0 +1,153 @@ > +Start with Documentation/process/submitting-patches.rst for general > +guidance. > + > +These are things I look at when reviewing patches. For an u

Re: [PATCH v1 1/2] PCI: Document patch submission hints

2018-06-29 Thread Lukas Wunner
On Fri, Jun 29, 2018 at 03:27:39PM -0500, Bjorn Helgaas wrote: > + - Wrap changelogs to fit in 80 columns when shown by "git show", which > +adds 4 spaces. I use "textwidth=75" in vim. I guess the ideal width is subjective, I usually wrap at 72 chars because then you've got 4 blanks on eithe