Re: [PATCH v1 02/15] perf report: output trace file name in raw trace dump

2020-10-20 Thread Andi Kleen
> > After brief evaluation it still doesn't look easy. The simplest thing > > I could imagine is to probably combine file_path and file_offset at a > > struct object on stack and then pass the object by the reference along > > function calls. I expect it will roughly cause the same amount of change

Re: [PATCH v1 02/15] perf report: output trace file name in raw trace dump

2020-10-20 Thread Alexey Budankov
On 20.10.2020 19:31, Alexey Budankov wrote: > > On 12.10.2020 20:06, Alexey Budankov wrote: >> >> On 12.10.2020 19:01, Andi Kleen wrote: >>> On Mon, Oct 12, 2020 at 11:54:24AM +0300, Alexey Budankov wrote: @@ -180,7 +183,8 @@ static int ordered_events__deliver_event(struct ordered_eve

Re: [PATCH v1 02/15] perf report: output trace file name in raw trace dump

2020-10-20 Thread Alexey Budankov
On 12.10.2020 20:06, Alexey Budankov wrote: > > On 12.10.2020 19:01, Andi Kleen wrote: >> On Mon, Oct 12, 2020 at 11:54:24AM +0300, Alexey Budankov wrote: >>> @@ -180,7 +183,8 @@ static int ordered_events__deliver_event(struct >>> ordered_events *oe, >>>

Re: [PATCH v1 02/15] perf report: output trace file name in raw trace dump

2020-10-13 Thread Alexey Budankov
Hi, On 13.10.2020 22:54, Jiri Olsa wrote: > On Mon, Oct 12, 2020 at 11:54:24AM +0300, Alexey Budankov wrote: >> >> Output path of a trace file into raw dump (-D) @. >> Print offset of PERF_RECORD_COMPRESSED record instead of zero for >> decompressed records: >> 0x22...@perf.data [0x30]: event: 9

Re: [PATCH v1 02/15] perf report: output trace file name in raw trace dump

2020-10-13 Thread Jiri Olsa
On Mon, Oct 12, 2020 at 11:54:24AM +0300, Alexey Budankov wrote: > > Output path of a trace file into raw dump (-D) @. > Print offset of PERF_RECORD_COMPRESSED record instead of zero for > decompressed records: > 0x22...@perf.data [0x30]: event: 9 > or > 0x15c...@perf.data/data.7 [0x30]: event

Re: [PATCH v1 02/15] perf report: output trace file name in raw trace dump

2020-10-12 Thread Alexey Budankov
On 12.10.2020 19:01, Andi Kleen wrote: > On Mon, Oct 12, 2020 at 11:54:24AM +0300, Alexey Budankov wrote: >> @@ -180,7 +183,8 @@ static int ordered_events__deliver_event(struct >> ordered_events *oe, >> ordered_events); >> >> return perf_se

Re: [PATCH v1 02/15] perf report: output trace file name in raw trace dump

2020-10-12 Thread Andi Kleen
On Mon, Oct 12, 2020 at 11:54:24AM +0300, Alexey Budankov wrote: > @@ -180,7 +183,8 @@ static int ordered_events__deliver_event(struct > ordered_events *oe, > ordered_events); > > return perf_session__deliver_event(session, event->event, >