Re: [PATCH v1] x86: fix kernel crash on boot due to NULL dereference

2014-07-21 Thread Andy Shevchenko
On Mon, 2014-07-21 at 10:31 +0800, Jiang Liu wrote: > Hi Andy, > Have you encountered any issue with another call site of > setup_irq() in arch/x86/kernel/time.c? No, since Intel MID uses its own .timer_init callback. > void __init setup_default_timer_irq(void) > { >

Re: [PATCH v1] x86: fix kernel crash on boot due to NULL dereference

2014-07-20 Thread Jiang Liu
Hi Andy, Have you encountered any issue with another call site of setup_irq() in arch/x86/kernel/time.c? void __init setup_default_timer_irq(void) { setup_irq(0, &irq0); } Seems it may need the same protection for system without legacy IRQ con

Re: [PATCH v1] x86: fix kernel crash on boot due to NULL dereference

2014-07-18 Thread Andy Shevchenko
On Fri, Jul 18, 2014 at 12:34 AM, David Cohen wrote: > Hi Andy, > > Thanks for the patch. > > On Thu, Jul 17, 2014 at 05:59:41PM +0300, Andy Shevchenko wrote: >> The patch "x86, irq: Count legacy IRQs by legacy_pic->nr_legacy_irqs instead >> of >> NR_IRQS_LEGACY" (linux-next commit 95d76acc7518d5

Re: [PATCH v1] x86: fix kernel crash on boot due to NULL dereference

2014-07-17 Thread David Cohen
Hi Andy, Thanks for the patch. On Thu, Jul 17, 2014 at 05:59:41PM +0300, Andy Shevchenko wrote: > The patch "x86, irq: Count legacy IRQs by legacy_pic->nr_legacy_irqs instead > of > NR_IRQS_LEGACY" (linux-next commit 95d76acc7518d566df18d67c1343bb375b78d1f3) > removed reserved interrupts for the