Re: [PATCH v1] drivers: make struct device_driver::remove return void

2020-11-25 Thread Uwe Kleine-König
Hello Julia, On Tue, Nov 10, 2020 at 04:07:23PM +0100, Uwe Kleine-König wrote: > diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c > index ecc304149067..ed79a5c657e5 100644 > --- a/drivers/amba/bus.c > +++ b/drivers/amba/bus.c > @@ -295,7 +295,7 @@ static int amba_probe(struct device *dev) >

Re: [PATCH v1] drivers: make struct device_driver::remove return void

2020-11-15 Thread kernel test robot
Hi "Uwe, I love your patch! Yet something to improve: [auto build test ERROR on 407ab579637ced6dc32cfb2295afb7259cca4b22] url: https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/drivers-make-struct-device_driver-remove-return-void/20201110-230939 base:407ab579637ced6dc32cfb2295afb

Re: [PATCH v1] drivers: make struct device_driver::remove return void

2020-11-13 Thread Greg Kroah-Hartman
On Thu, Nov 12, 2020 at 09:51:12AM +0100, Uwe Kleine-König wrote: > Hello Greg, > > On Tue, Nov 10, 2020 at 09:31:06PM +0100, Greg Kroah-Hartman wrote: > > On Tue, Nov 10, 2020 at 04:07:23PM +0100, Uwe Kleine-König wrote: > > > The driver core doesn't check the return value of the remove callback

Re: [PATCH v1] drivers: make struct device_driver::remove return void

2020-11-12 Thread Uwe Kleine-König
Hello Greg, On Tue, Nov 10, 2020 at 09:31:06PM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 10, 2020 at 04:07:23PM +0100, Uwe Kleine-König wrote: > > The driver core doesn't check the return value of the remove callback > > because there is only little software can do when hardware disappears. >

Re: [PATCH v1] drivers: make struct device_driver::remove return void

2020-11-10 Thread Greg Kroah-Hartman
On Tue, Nov 10, 2020 at 04:07:23PM +0100, Uwe Kleine-König wrote: > The driver core doesn't check the return value of the remove callback > because there is only little software can do when hardware disappears. > > So change the callback to not return a value at all and adapt all users. > The moti