Re: [PATCH v1] drivers/base/memory.c: Use DEVICE_ATTR_RO and friends

2018-12-05 Thread osalvador
On 2018-12-03 12:16, David Hildenbrand wrote: Let's use the easier to read (and not mess up) variants: - Use DEVICE_ATTR_RO - Use DEVICE_ATTR_WO - Use DEVICE_ATTR_RW instead of the more generic DEVICE_ATTR() we're using right now. We have to rename most callback functions. By fixing the intendat

Re: [PATCH v1] drivers/base/memory.c: Use DEVICE_ATTR_RO and friends

2018-12-05 Thread Greg Kroah-Hartman
On Mon, Dec 03, 2018 at 12:16:11PM +0100, David Hildenbrand wrote: > Let's use the easier to read (and not mess up) variants: > - Use DEVICE_ATTR_RO > - Use DEVICE_ATTR_WO > - Use DEVICE_ATTR_RW > instead of the more generic DEVICE_ATTR() we're using right now. > > We have to rename most callback

Re: [PATCH v1] drivers/base/memory.c: Use DEVICE_ATTR_RO and friends

2018-12-03 Thread Wei Yang
On Mon, Dec 03, 2018 at 12:16:11PM +0100, David Hildenbrand wrote: >Let's use the easier to read (and not mess up) variants: >- Use DEVICE_ATTR_RO >- Use DEVICE_ATTR_WO >- Use DEVICE_ATTR_RW >instead of the more generic DEVICE_ATTR() we're using right now. > >We have to rename most callback functio