Re: [PATCH v1] OLPC: use %*ph specifier instead of passing direct values

2015-10-06 Thread Darren Hart
On Wed, Sep 30, 2015 at 05:59:44PM +0300, Andy Shevchenko wrote: > On Mon, 2014-12-29 at 09:32 -0500, Paul Fox wrote: > > change looks okay to me. > > Acked-by: Paul Fox > > > > Darren, maybe you can apply this one? Seems OLPC is x86-based. Change is good, and olpc appears to be orphaned per M

Re: [PATCH v1] OLPC: use %*ph specifier instead of passing direct values

2015-09-30 Thread Andy Shevchenko
On Mon, 2014-12-29 at 09:32 -0500, Paul Fox wrote: > change looks okay to me. > Acked-by: Paul Fox > Darren, maybe you can apply this one? Seems OLPC is x86-based. > paul > > andy wrote: > > The %*ph specifier allows to dump small buffers in hex format. > Let's use it > > instead of passin

Re: [PATCH v1] OLPC: use %*ph specifier instead of passing direct values

2014-12-29 Thread Paul Fox
change looks okay to me. Acked-by: Paul Fox paul andy wrote: > The %*ph specifier allows to dump small buffers in hex format. Let's use it > instead of passing direct values via stack. > > Signed-off-by: Andy Shevchenko > --- > drivers/platform/olpc/olpc-ec.c | 13 + > 1 f