Re: [PATCH v1]] lib/btree.c: optimise the code by previously getpos function

2017-04-28 Thread Andy Shevchenko
On Tue, Apr 11, 2017 at 9:53 AM, Leno Hou wrote: > This patch optimized the code by previously getpos function call. > Therefore, It's takes the convenience to understand logic of code. Besides what Christoph told you (I agree with him, writing test suites / modules is quite good exercise for new

Re: [PATCH v1]] lib/btree.c: optimise the code by previously getpos function

2017-04-19 Thread Leno Hou
> On 13 Apr 2017, at 1:32 AM, Christoph Hellwig wrote: > > On Wed, Apr 12, 2017 at 06:03:10PM +0800, Leno Hou wrote: >> 1. Actually, this is cleanup of the code to human being read but not >> optimize. And When I compiled the kernel >>and checked with object code . It proved as same as befor

Re: [PATCH v1]] lib/btree.c: optimise the code by previously getpos function

2017-04-12 Thread Christoph Hellwig
On Wed, Apr 12, 2017 at 06:03:10PM +0800, Leno Hou wrote: > 1. Actually, this is cleanup of the code to human being read but not > optimize. And When I compiled the kernel > and checked with object code . It proved as same as before. So it's no > need to test this change. > > 2. This Simple B+

Re: [PATCH v1]] lib/btree.c: optimise the code by previously getpos function

2017-04-11 Thread Christoph Hellwig
On Tue, Apr 11, 2017 at 02:53:56AM -0400, Leno Hou wrote: > This patch optimized the code by previously getpos function call. > Therefore, It's takes the convenience to understand logic of code. How did you test this change?