Re: [PATCH next 3/4] blk-mq: user (1 << order) to implement order_to_size()

2014-04-18 Thread Jens Axboe
On Apr 18, 2014, at 8:17 PM, Ming Lei wrote: > >> On Sat, Apr 19, 2014 at 3:23 AM, Jörg-Volker Peetz wrote: >> >> Testing this with gcc 4.8.2 with order > 30 confirms that the automatic >> casting >> is done operator-wise and the explicit casting is necessary. > > My gcc 4.8.2 doesn't complai

Re: [PATCH next 3/4] blk-mq: user (1 << order) to implement order_to_size()

2014-04-18 Thread Ming Lei
On Sat, Apr 19, 2014 at 3:23 AM, Jörg-Volker Peetz wrote: > > Testing this with gcc 4.8.2 with order > 30 confirms that the automatic > casting > is done operator-wise and the explicit casting is necessary. My gcc 4.8.2 doesn't complain the change, see below: ming@ming:~/ming/linux$ gcc --versi

Re: [PATCH next 3/4] blk-mq: user (1 << order) to implement order_to_size()

2014-04-18 Thread Jörg-Volker Peetz
Ming Lei wrote, on 04/18/2014 17:47: > On Fri, Apr 18, 2014 at 3:03 AM, Jörg-Volker Peetz wrote: >> Ming Lei wrote, on 04/17/2014 17:49: >>> Signed-off-by: Ming Lei >>> --- >>> block/blk-mq.c |7 +-- >>> 1 file changed, 1 insertion(+), 6 deletions(-) >>> >>> diff --git a/block/blk-mq.c b

Re: [PATCH next 3/4] blk-mq: user (1 << order) to implement order_to_size()

2014-04-18 Thread Ming Lei
On Fri, Apr 18, 2014 at 3:03 AM, Jörg-Volker Peetz wrote: > Ming Lei wrote, on 04/17/2014 17:49: >> Signed-off-by: Ming Lei >> --- >> block/blk-mq.c |7 +-- >> 1 file changed, 1 insertion(+), 6 deletions(-) >> >> diff --git a/block/blk-mq.c b/block/blk-mq.c >> index baff2d0..1eff3d9 1006

Re: [PATCH next 3/4] blk-mq: user (1 << order) to implement order_to_size()

2014-04-17 Thread Max Filippov
On Thu, Apr 17, 2014 at 11:03 PM, Jörg-Volker Peetz wrote: > Ming Lei wrote, on 04/17/2014 17:49: >> Signed-off-by: Ming Lei >> --- >> block/blk-mq.c |7 +-- >> 1 file changed, 1 insertion(+), 6 deletions(-) >> >> diff --git a/block/blk-mq.c b/block/blk-mq.c >> index baff2d0..1eff3d9 100

Re: [PATCH next 3/4] blk-mq: user (1 << order) to implement order_to_size()

2014-04-17 Thread Jörg-Volker Peetz
Ming Lei wrote, on 04/17/2014 17:49: > Signed-off-by: Ming Lei > --- > block/blk-mq.c |7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index baff2d0..1eff3d9 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -1130,12 +113