Re: [PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up

2020-11-26 Thread Alex Shi
在 2020/11/26 下午11:23, Vlastimil Babka 写道: >>> >>> I tried that, and .text became significantly larger, for reasons which >>> I didn't investigate ;) > > I found out that comparing whole .text doesn't often work as changes might be > lost in alignment, or > once in a while cross the alignment b

Re: [PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up

2020-11-26 Thread Vlastimil Babka
On 11/26/20 3:25 AM, Alex Shi wrote: 在 2020/11/26 上午7:43, Andrew Morton 写道: On Tue, 24 Nov 2020 12:21:28 +0100 Vlastimil Babka wrote: On 11/22/20 3:00 PM, Alex Shi wrote: Thanks a lot for all comments, I picked all up and here is the v3: From 167131dd106a96fd08af725df850e0da6ec899af Mon

Re: [PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up

2020-11-25 Thread Alex Shi
在 2020/11/26 上午7:43, Andrew Morton 写道: > On Tue, 24 Nov 2020 12:21:28 +0100 Vlastimil Babka wrote: > >> On 11/22/20 3:00 PM, Alex Shi wrote: >>> Thanks a lot for all comments, I picked all up and here is the v3: >>> >>> From 167131dd106a96fd08af725df850e0da6ec899af Mon Sep 17 00:00:00 2001 >>

Re: [PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up

2020-11-25 Thread Andrew Morton
On Tue, 24 Nov 2020 12:21:28 +0100 Vlastimil Babka wrote: > On 11/22/20 3:00 PM, Alex Shi wrote: > > Thanks a lot for all comments, I picked all up and here is the v3: > > > > From 167131dd106a96fd08af725df850e0da6ec899af Mon Sep 17 00:00:00 2001 > > From: Alex Shi > > Date: Fri, 20 Nov 2020 1

Re: [PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up

2020-11-24 Thread Vlastimil Babka
On 11/22/20 3:00 PM, Alex Shi wrote: Thanks a lot for all comments, I picked all up and here is the v3: From 167131dd106a96fd08af725df850e0da6ec899af Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Fri, 20 Nov 2020 14:49:16 +0800 Subject: [PATCH v3 next] mm/vmscan: __isolate_lru_page_prepare cle

Re: [PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up

2020-11-22 Thread Alex Shi
在 2020/11/22 下午8:35, Matthew Wilcox 写道: > On Sun, Nov 22, 2020 at 08:00:19PM +0800, Alex Shi wrote: >> mm/compaction.c | 2 +- >> mm/vmscan.c | 69 +++-- >> 2 files changed, 34 insertions(+), 37 deletions(-) > > How is it possible you're changin

Re: [PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up

2020-11-22 Thread Matthew Wilcox
On Sun, Nov 22, 2020 at 08:00:19PM +0800, Alex Shi wrote: > mm/compaction.c | 2 +- > mm/vmscan.c | 69 +++-- > 2 files changed, 34 insertions(+), 37 deletions(-) How is it possible you're changing the signature of a function without touching a hea

Re: [PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up

2020-11-22 Thread Alex Shi
在 2020/11/21 上午7:13, Andrew Morton 写道: > On Fri, 20 Nov 2020 16:03:33 +0800 Alex Shi > wrote: > >> The function just return 2 results, so use a 'switch' to deal with its >> result is unnecessary, and simplify it to a bool func as Vlastimil >> suggested. >> >> Also removed 'goto' in using by r

Re: [PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up

2020-11-20 Thread Andrew Morton
On Fri, 20 Nov 2020 16:03:33 +0800 Alex Shi wrote: > The function just return 2 results, so use a 'switch' to deal with its > result is unnecessary, and simplify it to a bool func as Vlastimil > suggested. > > Also removed 'goto' in using by reusing list_move(). > > ... > > --- a/mm/vmscan.c >