Re: [PATCH net v1] net: phy: smsc: fix printing too many logs

2020-06-18 Thread Dejin Zheng
On Wed, Jun 17, 2020 at 11:36:42PM +0200, Andrew Lunn wrote: > On Wed, Jun 17, 2020 at 09:24:50PM +0100, Russell King - ARM Linux admin > wrote: > > On Wed, Jun 17, 2020 at 08:43:34PM +0200, Andrew Lunn wrote: > > > You have explained what the change does. But not why it is > > > needed. What exac

Re: [PATCH net v1] net: phy: smsc: fix printing too many logs

2020-06-17 Thread Andrew Lunn
On Wed, Jun 17, 2020 at 09:24:50PM +0100, Russell King - ARM Linux admin wrote: > On Wed, Jun 17, 2020 at 08:43:34PM +0200, Andrew Lunn wrote: > > You have explained what the change does. But not why it is > > needed. What exactly is happening. To me, the key thing is > > understanding why we get -

Re: [PATCH net v1] net: phy: smsc: fix printing too many logs

2020-06-17 Thread Russell King - ARM Linux admin
On Wed, Jun 17, 2020 at 08:43:34PM +0200, Andrew Lunn wrote: > You have explained what the change does. But not why it is > needed. What exactly is happening. To me, the key thing is > understanding why we get -110, and why it is not an actual error we > should be reporting as an error. That is wha

Re: [PATCH net v1] net: phy: smsc: fix printing too many logs

2020-06-17 Thread Andrew Lunn
On Thu, Jun 18, 2020 at 01:50:39AM +0800, Dejin Zheng wrote: > On Wed, Jun 17, 2020 at 06:19:25PM +0200, Andrew Lunn wrote: > > On Wed, Jun 17, 2020 at 11:33:40PM +0800, Dejin Zheng wrote: > > > Commit 7ae7ad2f11ef47 ("net: phy: smsc: use phy_read_poll_timeout() > > > to simplify the code") will pr

Re: [PATCH net v1] net: phy: smsc: fix printing too many logs

2020-06-17 Thread Dejin Zheng
On Wed, Jun 17, 2020 at 06:19:25PM +0200, Andrew Lunn wrote: > On Wed, Jun 17, 2020 at 11:33:40PM +0800, Dejin Zheng wrote: > > Commit 7ae7ad2f11ef47 ("net: phy: smsc: use phy_read_poll_timeout() > > to simplify the code") will print a lot of logs as follows when Ethernet > > cable is not connected

Re: [PATCH net v1] net: phy: smsc: fix printing too many logs

2020-06-17 Thread Andrew Lunn
On Wed, Jun 17, 2020 at 11:33:40PM +0800, Dejin Zheng wrote: > Commit 7ae7ad2f11ef47 ("net: phy: smsc: use phy_read_poll_timeout() > to simplify the code") will print a lot of logs as follows when Ethernet > cable is not connected: > > [4.473105] SMSC LAN8710/LAN8720 2188000.ethernet-1:00: >