Re: [PATCH net-next v7] selftests/vsock: add initial vmtest.sh for vsock

2025-05-20 Thread Bobby Eshleman
On Tue, May 20, 2025 at 01:09:25PM +0200, Stefano Garzarella wrote: > On Tue, May 20, 2025 at 12:58:18PM +0200, Paolo Abeni wrote: > > On 5/20/25 10:24 AM, Stefano Garzarella wrote: > > > > Still it could be worthy to re-introduce (behind a command line option) > > the ability to build the kernel

Re: [PATCH net-next v7] selftests/vsock: add initial vmtest.sh for vsock

2025-05-20 Thread Bobby Eshleman
On Tue, May 20, 2025 at 12:58:18PM +0200, Paolo Abeni wrote: > On 5/20/25 10:24 AM, Stefano Garzarella wrote: > > https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style > > @Bobby: AFAICS this now has all the ingredients to fit NIPA integration > am I correct? the last com

Re: [PATCH net-next v7] selftests/vsock: add initial vmtest.sh for vsock

2025-05-20 Thread Bobby Eshleman
On Tue, May 20, 2025 at 01:24:43PM +0200, Paolo Abeni wrote: > On 5/16/25 12:00 AM, Bobby Eshleman wrote: > > +tap_prefix() { > > + sed -e "s/^/${TAP_PREFIX}/" > > +} > > I think there is no need to the tap prefix to the output you intend to > 'comment out', the kselftest infra should already ad

Re: [PATCH net-next v7] selftests/vsock: add initial vmtest.sh for vsock

2025-05-20 Thread Paolo Abeni
On 5/16/25 12:00 AM, Bobby Eshleman wrote: > +tap_prefix() { > + sed -e "s/^/${TAP_PREFIX}/" > +} I think there is no need to the tap prefix to the output you intend to 'comment out', the kselftest infra should already add the tap prefix mark to each line generated by the test, > + > +tap_out

Re: [PATCH net-next v7] selftests/vsock: add initial vmtest.sh for vsock

2025-05-20 Thread Stefano Garzarella
On Tue, May 20, 2025 at 12:58:18PM +0200, Paolo Abeni wrote: On 5/20/25 10:24 AM, Stefano Garzarella wrote: On Thu, May 15, 2025 at 03:00:48PM -0700, Bobby Eshleman wrote: This commit introduces a new vmtest.sh runner for vsock. It uses virtme-ng/qemu to run tests in a VM. The tests validate G

Re: [PATCH net-next v7] selftests/vsock: add initial vmtest.sh for vsock

2025-05-20 Thread Paolo Abeni
On 5/20/25 10:24 AM, Stefano Garzarella wrote: > On Thu, May 15, 2025 at 03:00:48PM -0700, Bobby Eshleman wrote: >> This commit introduces a new vmtest.sh runner for vsock. >> >> It uses virtme-ng/qemu to run tests in a VM. The tests validate G2H, >> H2G, and loopback. The testing tools from tools/

Re: [PATCH net-next v7] selftests/vsock: add initial vmtest.sh for vsock

2025-05-20 Thread Stefano Garzarella
On Thu, May 15, 2025 at 03:00:48PM -0700, Bobby Eshleman wrote: This commit introduces a new vmtest.sh runner for vsock. It uses virtme-ng/qemu to run tests in a VM. The tests validate G2H, H2G, and loopback. The testing tools from tools/testing/vsock/ are reused. Currently, only vsock_test is u