Re: [PATCH net-next v4 3/4] virtio-net: Map NAPIs to queues

2025-02-26 Thread Joe Damato
On Thu, Feb 27, 2025 at 12:18:33PM +0800, Jason Wang wrote: > On Thu, Feb 27, 2025 at 6:13 AM Michael S. Tsirkin wrote: > > > > On Wed, Feb 26, 2025 at 03:27:42PM -0500, Joe Damato wrote: > > > On Wed, Feb 26, 2025 at 01:08:49PM -0500, Joe Damato wrote: > > > > On Wed, Feb 26, 2025 at 01:03:09PM -

Re: [PATCH net-next v4 3/4] virtio-net: Map NAPIs to queues

2025-02-26 Thread Jason Wang
On Thu, Feb 27, 2025 at 6:13 AM Michael S. Tsirkin wrote: > > On Wed, Feb 26, 2025 at 03:27:42PM -0500, Joe Damato wrote: > > On Wed, Feb 26, 2025 at 01:08:49PM -0500, Joe Damato wrote: > > > On Wed, Feb 26, 2025 at 01:03:09PM -0500, Joe Damato wrote: > > > > On Wed, Feb 26, 2025 at 01:48:50PM +08

Re: [PATCH net-next v4 3/4] virtio-net: Map NAPIs to queues

2025-02-26 Thread Michael S. Tsirkin
On Wed, Feb 26, 2025 at 03:27:42PM -0500, Joe Damato wrote: > On Wed, Feb 26, 2025 at 01:08:49PM -0500, Joe Damato wrote: > > On Wed, Feb 26, 2025 at 01:03:09PM -0500, Joe Damato wrote: > > > On Wed, Feb 26, 2025 at 01:48:50PM +0800, Jason Wang wrote: > > > > On Tue, Feb 25, 2025 at 10:05 AM Joe Da

Re: [PATCH net-next v4 3/4] virtio-net: Map NAPIs to queues

2025-02-26 Thread Michael S. Tsirkin
On Wed, Feb 26, 2025 at 01:03:09PM -0500, Joe Damato wrote: > On Wed, Feb 26, 2025 at 01:48:50PM +0800, Jason Wang wrote: > > On Tue, Feb 25, 2025 at 10:05 AM Joe Damato wrote: > > > > > > Use netif_queue_set_napi to map NAPIs to queue IDs so that the mapping > > > can be accessed by user apps, ta

Re: [PATCH net-next v4 3/4] virtio-net: Map NAPIs to queues

2025-02-26 Thread Joe Damato
On Wed, Feb 26, 2025 at 01:08:49PM -0500, Joe Damato wrote: > On Wed, Feb 26, 2025 at 01:03:09PM -0500, Joe Damato wrote: > > On Wed, Feb 26, 2025 at 01:48:50PM +0800, Jason Wang wrote: > > > On Tue, Feb 25, 2025 at 10:05 AM Joe Damato wrote: > > > > > > > > Use netif_queue_set_napi to map NAPIs t

Re: [PATCH net-next v4 3/4] virtio-net: Map NAPIs to queues

2025-02-26 Thread Joe Damato
On Wed, Feb 26, 2025 at 01:03:09PM -0500, Joe Damato wrote: > On Wed, Feb 26, 2025 at 01:48:50PM +0800, Jason Wang wrote: > > On Tue, Feb 25, 2025 at 10:05 AM Joe Damato wrote: > > > > > > Use netif_queue_set_napi to map NAPIs to queue IDs so that the mapping > > > can be accessed by user apps, ta

Re: [PATCH net-next v4 3/4] virtio-net: Map NAPIs to queues

2025-02-26 Thread Joe Damato
On Wed, Feb 26, 2025 at 01:48:50PM +0800, Jason Wang wrote: > On Tue, Feb 25, 2025 at 10:05 AM Joe Damato wrote: > > > > Use netif_queue_set_napi to map NAPIs to queue IDs so that the mapping > > can be accessed by user apps, taking care to hold RTNL as needed. > > I may miss something but I wond

Re: [PATCH net-next v4 3/4] virtio-net: Map NAPIs to queues

2025-02-25 Thread Jason Wang
On Tue, Feb 25, 2025 at 10:05 AM Joe Damato wrote: > > Use netif_queue_set_napi to map NAPIs to queue IDs so that the mapping > can be accessed by user apps, taking care to hold RTNL as needed. I may miss something but I wonder whether letting the caller hold the lock is better. More below. > >