RE: [PATCH net-next 0/9] r8169:update hardware ephy parameter

2014-12-09 Thread Hau
> From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, December 10, 2014 7:36 AM > To: Hau > Cc: net...@vger.kernel.org; nic_swsd; linux-kernel@vger.kernel.org > Subject: Re: [PATCH net-next 0/9] r8169:update hardware ephy parameter > > From: Chunhao Lin > D

Re: [PATCH net-next 0/9] r8169:update hardware ephy parameter

2014-12-09 Thread Francois Romieu
Chunhao Lin : > Update hardware ephy parameter to improve pcie compatibility. Neither the code nor the commit message helps to figure which kind of behavioral change should/could be expected. Bandwidth ? Latency ? Power management ? Compliance ? Stability ? -- Ueimor -- To unsubscribe from thi

Re: [PATCH net-next 0/9] r8169:update hardware ephy parameter

2014-12-09 Thread David Miller
From: Chunhao Lin Date: Wed, 10 Dec 2014 00:45:54 +0800 > Update hardware ephy parameter to improve pcie compatibility. This really doesn't tell me anything, I really dislike patch series like this one. All of the programming is magic values to magic offsets. You aren't even trying to describe