Re: [PATCH net-next] tuntap: hardware vlan tx support

2013-07-24 Thread Jason Wang
On 07/24/2013 11:11 PM, Stephen Hemminger wrote: > On Wed, 24 Jul 2013 13:55:14 +0800 > Jason Wang wrote: > >> On 07/23/2013 11:53 PM, Stephen Hemminger wrote: >>> On Tue, 23 Jul 2013 15:15:48 +0800 >>> Jason Wang wrote: >>> + struct { + __be16 h_vlan_proto; >>

Re: [PATCH net-next] tuntap: hardware vlan tx support

2013-07-24 Thread Stephen Hemminger
On Wed, 24 Jul 2013 13:55:14 +0800 Jason Wang wrote: > On 07/23/2013 11:53 PM, Stephen Hemminger wrote: > > On Tue, 23 Jul 2013 15:15:48 +0800 > > Jason Wang wrote: > > > >> + struct { > >> + __be16 h_vlan_proto; > >> + __be16 h_vlan_TCI; > >> +

Re: [PATCH net-next] tuntap: hardware vlan tx support

2013-07-23 Thread Jason Wang
On 07/23/2013 11:53 PM, Stephen Hemminger wrote: > On Tue, 23 Jul 2013 15:15:48 +0800 > Jason Wang wrote: > >> +struct { >> +__be16 h_vlan_proto; >> +__be16 h_vlan_TCI; >> +} veth; > Don't you want to use struct vlan_hdr here? There

Re: [PATCH net-next] tuntap: hardware vlan tx support

2013-07-23 Thread Jason Wang
On 07/23/2013 11:17 PM, Stephen Hemminger wrote: > On Tue, 23 Jul 2013 15:15:48 +0800 > Jason Wang wrote: > >> Inspired by commit f09e2249c4f5c7c13261ec73f5a7807076af0c8e (macvtap: restore >> vlan header on user read). This patch adds hardware vlan tx support for >> tuntap. This is done by copying

Re: [PATCH net-next] tuntap: hardware vlan tx support

2013-07-23 Thread Jason Wang
On 07/23/2013 08:12 PM, Sergei Shtylyov wrote: > Hello. > > On 23-07-2013 11:15, Jason Wang wrote: > >> Inspired by commit f09e2249c4f5c7c13261ec73f5a7807076af0c8e (macvtap: >> restore >> vlan header on user read). This patch adds hardware vlan tx support for >> tuntap. This is done by copying vlan

Re: [PATCH net-next] tuntap: hardware vlan tx support

2013-07-23 Thread Stephen Hemminger
On Tue, 23 Jul 2013 15:15:48 +0800 Jason Wang wrote: > + struct { > + __be16 h_vlan_proto; > + __be16 h_vlan_TCI; > + } veth; Don't you want to use struct vlan_hdr here? Your definition puts the two fields out of order? -- To unsub

Re: [PATCH net-next] tuntap: hardware vlan tx support

2013-07-23 Thread Michael S. Tsirkin
On Tue, Jul 23, 2013 at 08:17:27AM -0700, Stephen Hemminger wrote: > On Tue, 23 Jul 2013 15:15:48 +0800 > Jason Wang wrote: > > > Inspired by commit f09e2249c4f5c7c13261ec73f5a7807076af0c8e (macvtap: > > restore > > vlan header on user read). This patch adds hardware vlan tx support for > > tunt

Re: [PATCH net-next] tuntap: hardware vlan tx support

2013-07-23 Thread Stephen Hemminger
On Tue, 23 Jul 2013 15:15:48 +0800 Jason Wang wrote: > Inspired by commit f09e2249c4f5c7c13261ec73f5a7807076af0c8e (macvtap: restore > vlan header on user read). This patch adds hardware vlan tx support for > tuntap. This is done by copying vlan header directly into userspace in > tun_put_user()

Re: [PATCH net-next] tuntap: hardware vlan tx support

2013-07-23 Thread Sergei Shtylyov
Hello. On 23-07-2013 11:15, Jason Wang wrote: Inspired by commit f09e2249c4f5c7c13261ec73f5a7807076af0c8e (macvtap: restore vlan header on user read). This patch adds hardware vlan tx support for tuntap. This is done by copying vlan header directly into userspace in tun_put_user() instead of do