Re: [PATCH net-next] openvswitch: Fix serialization of non-masked set actions.

2015-03-03 Thread David Miller
From: Joe Stringer Date: Tue, 3 Mar 2015 12:38:54 -0800 > On 3 March 2015 at 11:39, David Miller wrote: >> From: Joe Stringer >> Date: Mon, 2 Mar 2015 18:49:56 -0800 >> >>> Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside >>> of a OVS_ACTION_ATTR_SET action attribute. Wh

Re: [PATCH net-next] openvswitch: Fix serialization of non-masked set actions.

2015-03-03 Thread Joe Stringer
On 3 March 2015 at 12:38, Joe Stringer wrote: > On 3 March 2015 at 11:39, David Miller wrote: >> From: Joe Stringer >> Date: Mon, 2 Mar 2015 18:49:56 -0800 >> >>> Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside >>> of a OVS_ACTION_ATTR_SET action attribute. When converti

Re: [PATCH net-next] openvswitch: Fix serialization of non-masked set actions.

2015-03-03 Thread Joe Stringer
On 3 March 2015 at 11:39, David Miller wrote: > From: Joe Stringer > Date: Mon, 2 Mar 2015 18:49:56 -0800 > >> Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside >> of a OVS_ACTION_ATTR_SET action attribute. When converting masked actions >> back to regular set actions, the

Re: [PATCH net-next] openvswitch: Fix serialization of non-masked set actions.

2015-03-03 Thread David Miller
From: Joe Stringer Date: Mon, 2 Mar 2015 18:49:56 -0800 > Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside > of a OVS_ACTION_ATTR_SET action attribute. When converting masked actions > back to regular set actions, the inner attribute length was not changed, > ie, double th

Re: [PATCH net-next] openvswitch: Fix serialization of non-masked set actions.

2015-03-03 Thread Jarno Rajahalme
Thanks for spotting and fixing this, Acked-by: Jarno Rajahalme > On Mar 2, 2015, at 6:49 PM, Joe Stringer wrote: > > Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside > of a OVS_ACTION_ATTR_SET action attribute. When converting masked actions > back to regular set actions