Re: [External] Re: [PATCH net] virtio-net: fix a rtnl_lock() deadlock during probing

2025-07-01 Thread Michael S. Tsirkin
On Tue, Jul 01, 2025 at 03:48:41PM +0800, Zigit Zo wrote: > On 6/30/25 10:54 PM, Michael S. Tsirkin wrote: > > On Mon, Jun 30, 2025 at 10:50:55AM -0400, Michael S. Tsirkin wrote: > >> On Mon, Jun 30, 2025 at 05:51:09PM +0800, Zigit Zo wrote: > >>> This bug happens if the VMM sends a VIRTIO_NET_S_AN

Re: [External] Re: [PATCH net] virtio-net: fix a rtnl_lock() deadlock during probing

2025-07-01 Thread Zigit Zo
On 6/30/25 10:54 PM, Michael S. Tsirkin wrote: > On Mon, Jun 30, 2025 at 10:50:55AM -0400, Michael S. Tsirkin wrote: >> On Mon, Jun 30, 2025 at 05:51:09PM +0800, Zigit Zo wrote: >>> This bug happens if the VMM sends a VIRTIO_NET_S_ANNOUNCE request while >>> the virtio-net driver is still probing wi

Re: [PATCH net] virtio-net: fix a rtnl_lock() deadlock during probing

2025-06-30 Thread Michael S. Tsirkin
On Mon, Jun 30, 2025 at 10:50:55AM -0400, Michael S. Tsirkin wrote: > On Mon, Jun 30, 2025 at 05:51:09PM +0800, Zigit Zo wrote: > > This bug happens if the VMM sends a VIRTIO_NET_S_ANNOUNCE request while > > the virtio-net driver is still probing with rtnl_lock() hold, this will > > cause a recursi

Re: [PATCH net] virtio-net: fix a rtnl_lock() deadlock during probing

2025-06-30 Thread Michael S. Tsirkin
On Mon, Jun 30, 2025 at 05:51:09PM +0800, Zigit Zo wrote: > This bug happens if the VMM sends a VIRTIO_NET_S_ANNOUNCE request while > the virtio-net driver is still probing with rtnl_lock() hold, this will > cause a recursive mutex in netdev_notify_peers(). > > Fix it by skip acking the annouce in

Re: [PATCH net] virtio-net: fix a rtnl_lock() deadlock during probing

2025-06-30 Thread Markus Elfring
… > Fix it by skip acking the annouce in virtnet_config_changed_work() when … announce? Regards, Markus